Add Turbulent Orographic Form Drag to SFCLAY#2284
Open
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Open
Add Turbulent Orographic Form Drag to SFCLAY#2284Songyou184 wants to merge 3 commits intowrf-model:developfrom
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Conversation
Collaborator
|
Note for @islas and @weiwangncar |
Collaborator
|
@Songyou184 @dudhia See my email on how to use submodules. |
Collaborator
|
The regression test results: |
Collaborator
|
Needs updating to resolve conflicts. |
Collaborator
|
@Songyou184 @dudhia Can you update the PR message? Thanks! |
Collaborator
|
@Songyou184 @dudhia If you can add some notes on expected outcome, that would be nice. |
dudhia
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: new feature
KEYWORDS: surface layer, turbulent form drag
SOURCE: Songyou Hong
DESCRIPTION OF CHANGES:
Turbulent form drag (TOFD) was added in computing surface drag (kim_tofd=.true., default). A factor for TOFD was added (tofd_factor=.003, default).
LIST OF MODIFIED FILES:
M arch/Externals.cfg
M dyn_em/module_first_rk_step_part1.F
M phys/module_sf_sfclayrev.F
M phys/module_surface_driver.F
TESTS CONDUCTED:
The Jenkins tests are all passing.
RELEASE NOTE: Addition of scale-aware TOFD switch (kim_tofd=.true.). Also note default true would increase surface drag. This needs evaluating.