Skip to content

Add Turbulent Orographic Form Drag to SFCLAY#2284

Open
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Songyou184:SFCLAY2026
Open

Add Turbulent Orographic Form Drag to SFCLAY#2284
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Songyou184:SFCLAY2026

Conversation

@Songyou184
Copy link

@Songyou184 Songyou184 commented Feb 19, 2026

TYPE: new feature

KEYWORDS: surface layer, turbulent form drag

SOURCE: Songyou Hong

DESCRIPTION OF CHANGES:
Turbulent form drag (TOFD) was added in computing surface drag (kim_tofd=.true., default). A factor for TOFD was added (tofd_factor=.003, default).

LIST OF MODIFIED FILES:
M arch/Externals.cfg
M dyn_em/module_first_rk_step_part1.F
M phys/module_sf_sfclayrev.F
M phys/module_surface_driver.F

TESTS CONDUCTED:
The Jenkins tests are all passing.

RELEASE NOTE: Addition of scale-aware TOFD switch (kim_tofd=.true.). Also note default true would increase surface drag. This needs evaluating.

@Songyou184 Songyou184 requested review from a team as code owners February 19, 2026 22:01
@dudhia
Copy link
Collaborator

dudhia commented Feb 19, 2026

Note for @islas and @weiwangncar
Songyou is splitting his PR into three parts. This currently uses manage_externals which probably needs changing.

@weiwangncar
Copy link
Collaborator

@Songyou184 @dudhia See my email on how to use submodules.

@Songyou184 Songyou184 requested a review from a team as a code owner February 20, 2026 16:48
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@dudhia
Copy link
Collaborator

dudhia commented Mar 4, 2026

Needs updating to resolve conflicts.

dudhia
dudhia previously approved these changes Mar 4, 2026
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code

@weiwangncar
Copy link
Collaborator

@Songyou184 @dudhia Can you update the PR message? Thanks!

@weiwangncar weiwangncar changed the title SFCLAY 2026 : # 1 of GWDO-SHPBL PR Add Turbulent Orographic Form Drag to SFCLAY Mar 5, 2026
@weiwangncar
Copy link
Collaborator

@Songyou184 @dudhia If you can add some notes on expected outcome, that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants