Claude/rh definition mixactivate ajs0 x#2266
Closed
liranpeng wants to merge 8 commits intowrf-model:masterfrom
Closed
Claude/rh definition mixactivate ajs0 x#2266liranpeng wants to merge 8 commits intowrf-model:masterfrom
liranpeng wants to merge 8 commits intowrf-model:masterfrom
Conversation
Fix bug and do not load every time.
This commit adds a new namelist parameter `use_ml_activate` that allows users to easily switch between ML-based activation (activate_ml) and traditional activation (activate) methods via the namelist. Changes: - Registry/Registry.EM: Added use_ml_activate namelist flag (default=1) - phys/module_mixactivate.F: * Added config_flags parameter to mixactivate and prescribe_aerosol_mixactivate * Added conditional logic to call activate_ml or activate based on flag - chem/module_mixactivate_wrappers.F: Updated all wrapper calls to pass config_flags - phys/module_microphysics_driver.F: Updated prescribe_aerosol_mixactivate call Usage in namelist.input: &physics use_ml_activate = 1 ! Use ML activation (activate_ml) use_ml_activate = 0 ! Use traditional activation (activate) /
Collaborator
|
@liranpeng The regression tests failed on compilation. I'm attaching one output file here. Please make sure you can compile the code on your local system before submitting a PR. Compilation errors are shown in the attatched file. Please also fill the PR template so that the code reviewers will know what is being changed. |
Two wrapper subroutines (sorgam_vbs_mixactivate) had different indentation and were not caught by the initial replacement. This commit adds config_flags to those remaining calls.
Collaborator
|
@liranpeng Your last commit didn't fix the compilation issue... The tests still failed. |
Collaborator
|
This option seems to require a very large number of extra 3d arrays that are not packaged with the namelist option. |
Author
Collaborator
|
Thanks. I will label it as not for release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first line should be a single-line "purpose" for this change
TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]
KEYWORDS: 5 to 10 words related to commit, separated by commas
SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member
DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?
Solution:
What was down algorithmically and in the source code to address the problem?
ISSUE: For use when this PR closes an issue.
Fixes #123
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)TESTS CONDUCTED:
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.