Fix errant line contiuation syntax in chem code#2223
Merged
islas merged 1 commit intowrf-model:release-v4.7.1from May 21, 2025
Merged
Fix errant line contiuation syntax in chem code#2223islas merged 1 commit intowrf-model:release-v4.7.1from
islas merged 1 commit intowrf-model:release-v4.7.1from
Conversation
weiwangncar
approved these changes
May 6, 2025
Collaborator
|
The regression test results: |
smileMchen
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: syntax
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
There is invalid Fortran syntax for line continuation in the chem code. More sensitive compilers catch this as an error during the CMake build as files are not sanitized as much compared to the make build.
Solution:
Change the lines to be a single line.
ISSUE:
#2214
TESTS CONDUCTED: