confcheck results passed to main CMakeLists.txt#2219
Merged
islas merged 1 commit intowrf-model:release-v4.7.1from May 30, 2025
Merged
confcheck results passed to main CMakeLists.txt#2219islas merged 1 commit intowrf-model:release-v4.7.1from
islas merged 1 commit intowrf-model:release-v4.7.1from
Conversation
islas
approved these changes
May 29, 2025
mgduda
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the results of the confchecks not getting passed correctly to the main CMakeLists.txt.
TYPE: bugfix
KEYWORDS: bugfix, CMake, confcheck
SOURCE: Max Balsmeier
DESCRIPTION OF CHANGES:
Problem:
See #2217
Solution:
The result variables of the confchecks are set with the PARENT_SCOPE attribute in confcheck/CMakeLists.txt.
ISSUE:
Fixes #2217
LIST OF MODIFIED FILES: confcheck/CMakeLists.txt
TESTS CONDUCTED:
RELEASE NOTE: Bugfix: CMake confcheck result variables passed correctly to main CMakeLists.txt.