Correct stability functions#2119
Closed
andreazonato wants to merge 2 commits intowrf-model:masterfrom
andreazonato:correct_stability_functions
Closed
Correct stability functions#2119andreazonato wants to merge 2 commits intowrf-model:masterfrom andreazonato:correct_stability_functions
andreazonato wants to merge 2 commits intowrf-model:masterfrom
andreazonato:correct_stability_functions
Conversation
added 2 commits
June 12, 2024 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first line should be a single-line "purpose" for this change
TYPE: bug fix
KEYWORDS: PBL closure, k-epsilon, stability functions
SOURCE: Andrea Zonato, Royal Netherlands Meteorological Institute (KNMI), The Netherlands
DESCRIPTION OF CHANGES:
Problem:
the tke-epsilon-tpe scheme uses stability functions at the surface (phim,phieps) to calculate the boundary conditions for tke and epsilon. In the original code, it calls psim and psih from module_sf_sfclayrev.F90, while the other PBL schemes call fm and fhh
Solution:
call fm and fh instead of psim,psih in module_bl_keps
ISSUE: For use when this PR closes an issue.
Fixes #123
LIST OF MODIFIED FILES:
module_pbl_driver.F
module_bl_keps.F
TESTS CONDUCTED:
RELEASE NOTE:
Updated stability functions are taken in the tke-epsilon-tpe PBL scheme Zonato et al, 2022, in order to make the model compatible with the other WRF PBL schemes.