Corrected end date for em_b_wave test case #2107
Merged
weiwangncar merged 1 commit intowrf-model:release-v4.6.1from Oct 14, 2024
Merged
Corrected end date for em_b_wave test case #2107weiwangncar merged 1 commit intowrf-model:release-v4.6.1from
weiwangncar merged 1 commit intowrf-model:release-v4.6.1from
Conversation
The end days not correspond to a 5 day run
Collaborator
|
The regression test results: |
Collaborator
|
@JeroBnd It's probably good to set the end day corresponding to the forecast days. However these end_* time variables are only used for real data cases to specify the end of BC time. These are not used for idealized cases. |
Contributor
Author
|
@weiwangncar Indeed, those variables aren't used in the ideal case, but they could be confusing for new WRF users. It might be best to delete those lines or comment them out (with the correct values). |
weiwangncar
previously approved these changes
Sep 13, 2024
weiwangncar
approved these changes
Sep 18, 2024
weiwangncar
previously approved these changes
Sep 18, 2024
weiwangncar
approved these changes
Oct 10, 2024
dudhia
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: no impact directly in the run
KEYWORDS: namelist, end_date, b_wave
SOURCE: Jeronimo Bande (IDING SAS)
DESCRIPTION OF CHANGES:
Problem:
Wrong end date in namelist. Not good for example.
Solution:
Correct end date of the simulation.
LIST OF MODIFIED FILES:
test/em_b_wave/namelist.input
TESTS CONDUCTED:
Jenkins tests are all passing.