Skip to content

Corrected end date for em_b_wave test case #2107

Merged
weiwangncar merged 1 commit intowrf-model:release-v4.6.1from
JeroBnd:patch-2
Oct 14, 2024
Merged

Corrected end date for em_b_wave test case #2107
weiwangncar merged 1 commit intowrf-model:release-v4.6.1from
JeroBnd:patch-2

Conversation

@JeroBnd
Copy link
Contributor

@JeroBnd JeroBnd commented Sep 12, 2024

TYPE: no impact directly in the run

KEYWORDS: namelist, end_date, b_wave

SOURCE: Jeronimo Bande (IDING SAS)

DESCRIPTION OF CHANGES:
Problem:
Wrong end date in namelist. Not good for example.

Solution:
Correct end date of the simulation.

LIST OF MODIFIED FILES:
test/em_b_wave/namelist.input

TESTS CONDUCTED:
Jenkins tests are all passing.

The end days not correspond to a 5 day run
@JeroBnd JeroBnd changed the title Corrected end date Corrected end date for em_b_wave test case Sep 12, 2024
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator

@JeroBnd It's probably good to set the end day corresponding to the forecast days. However these end_* time variables are only used for real data cases to specify the end of BC time. These are not used for idealized cases.

@JeroBnd
Copy link
Contributor Author

JeroBnd commented Sep 13, 2024

@weiwangncar Indeed, those variables aren't used in the ideal case, but they could be confusing for new WRF users. It might be best to delete those lines or comment them out (with the correct values).

weiwangncar
weiwangncar previously approved these changes Sep 13, 2024
@islas islas changed the base branch from master to develop September 13, 2024 21:27
@islas islas dismissed weiwangncar’s stale review September 13, 2024 21:27

The base branch was changed.

weiwangncar
weiwangncar previously approved these changes Sep 18, 2024
@weiwangncar weiwangncar changed the base branch from develop to release-v4.6.1 September 18, 2024 14:45
@weiwangncar weiwangncar dismissed their stale review September 18, 2024 14:45

The base branch was changed.

@weiwangncar weiwangncar merged commit a9c2337 into wrf-model:release-v4.6.1 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants