Skip to content

Add reflectivity calculation back to WSM6 scheme#2098

Merged
weiwangncar merged 6 commits intowrf-model:release-v4.6.1from
weiwangncar:wsm6_ref_fix
Aug 30, 2024
Merged

Add reflectivity calculation back to WSM6 scheme#2098
weiwangncar merged 6 commits intowrf-model:release-v4.6.1from
weiwangncar:wsm6_ref_fix

Conversation

@weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Aug 21, 2024

TYPE: bug fix

KEYWORDS: radar reflectivity, WSM6

SOURCE: reported by Gabriel Cassol of Sigma Meteorologia, Brazil, internal

DESCRIPTION OF CHANGES:
Problem:
When moving WSM6 to MMM shared physics directory, the calculation of radar reflectivity was left out.

Solution:
The calculation of radar reflectivity is added back in the WSM6 scheme.

ISSUE: For use when this PR closes an issue.
Fixes #2096

LIST OF MODIFIED FILES:
M phys/module_mp_wsm6.F

TESTS CONDUCTED:

  1. The reflectivity is computed now when namelist do_radar_ref is set to 1.
  2. The Jenkins tests are all passing.

RELEASE NOTE: Fixed the bug of missing radar reflectivity in WSM6 scheme when do_radar_ref is set to 1.

@weiwangncar weiwangncar requested a review from a team as a code owner August 21, 2024 03:12
dudhia
dudhia previously approved these changes Aug 27, 2024
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not seeing if Jenkins tests were done

@weiwangncar
Copy link
Collaborator Author

@dudhia As you can see I have been trying to start the tests a few times, but so far no success. Not sure what's going on.

@weiwangncar
Copy link
Collaborator Author

The Jenkins test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator Author

@dudhia @smileMchen Ready to be reviewed and approved.

@weiwangncar weiwangncar merged commit 0ca0d96 into wrf-model:release-v4.6.1 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants