Add reflectivity calculation back to WSM6 scheme#2098
Merged
weiwangncar merged 6 commits intowrf-model:release-v4.6.1from Aug 30, 2024
Merged
Add reflectivity calculation back to WSM6 scheme#2098weiwangncar merged 6 commits intowrf-model:release-v4.6.1from
weiwangncar merged 6 commits intowrf-model:release-v4.6.1from
Conversation
dudhia
previously approved these changes
Aug 27, 2024
Collaborator
dudhia
left a comment
There was a problem hiding this comment.
not seeing if Jenkins tests were done
Collaborator
Author
|
@dudhia As you can see I have been trying to start the tests a few times, but so far no success. Not sure what's going on. |
Collaborator
Author
|
The Jenkins test results: |
Collaborator
Author
|
@dudhia @smileMchen Ready to be reviewed and approved. |
dudhia
approved these changes
Aug 29, 2024
smileMchen
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: radar reflectivity, WSM6
SOURCE: reported by Gabriel Cassol of Sigma Meteorologia, Brazil, internal
DESCRIPTION OF CHANGES:
Problem:
When moving WSM6 to MMM shared physics directory, the calculation of radar reflectivity was left out.
Solution:
The calculation of radar reflectivity is added back in the WSM6 scheme.
ISSUE: For use when this PR closes an issue.
Fixes #2096
LIST OF MODIFIED FILES:
M phys/module_mp_wsm6.F
TESTS CONDUCTED:
RELEASE NOTE: Fixed the bug of missing radar reflectivity in WSM6 scheme when do_radar_ref is set to 1.