Warn users when projection is inappropriate for GWD_OPT=1#208
Closed
davegill wants to merge 7 commits intowrf-model:masterfrom
davegill:GWD_OPT_BULLETS
Closed
Warn users when projection is inappropriate for GWD_OPT=1#208davegill wants to merge 7 commits intowrf-model:masterfrom davegill:GWD_OPT_BULLETS
davegill wants to merge 7 commits intowrf-model:masterfrom
davegill:GWD_OPT_BULLETS
Conversation
TYPE: new feature KEYWORDS: gwd_opt, projection SOURCE: internal DESCRIPTION OF CHANGES: In the WRF model for domain 1, if the projection has a large sinalpha (where it is larger than a default value), notify the user and stop. LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list) M dyn_em/start_em.F TESTS CONDUCTED: - [ ] Reggie 3.07, checked means that is has been run
Contributor
Author
|
swap the degrees for the sin of the variable that is max allowed |
Contributor
Author
|
ask Jimy for a reasonable value |
Collaborator
|
yes, we discussed 22.5 degrees as the data is every 45 degrees of rotation.
…On Fri, Mar 24, 2017 at 11:20 AM, Dave Gill ***@***.***> wrote:
ask Jimy for a reasonable value
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#208 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARGf_J18caTDBdMcXwMMZviRxn-zJXR0ks5ro_tDgaJpZM4MnisT>
.
|
Set value to 22.5 degrees as max (half of 45 degrees), original data at 45 degree directions
jamiebresch
reviewed
Mar 24, 2017
dyn_em/start_em.F
Outdated
| END DO | ||
| END DO | ||
| #if ( defined(DM_PARALLEL) && ! defined(STUBMPI) ) | ||
| max_sa = wrf_dm_max_real ( max_sa ) |
Contributor
There was a problem hiding this comment.
max_sa? Do you mean max_rot_angle?
Contributor
Author
There was a problem hiding this comment.
@jamiebresch
My test was serial, so I never saw this compiler oops
Thanks
Contributor
Author
|
I ran this branch 4 times through the WTF v3.07. Each time it failed serial PGI for all of ARW. No compiler errors. I merged it to the repo top, and it passed. I am proposing the merged version #213 |
This was referenced Mar 27, 2017
davegill
added a commit
that referenced
this pull request
Mar 31, 2017
TYPE: new feature KEYWORDS: gwd_opt, projection SOURCE: internal DESCRIPTION OF CHANGES: This PR supersedes PR #208, which was closed. Assume that the user is trying to use gravity wave drag (GWD), gwd_opt=1, in the ARW model. For domain 1, if the projection has a large rotation angle anywhere within the domain ("rotation" is directly from the sina variable in the WRF input and output, and "large" means greater than a default value of 22.5o), notify the user and stop. The original GWD data has information at four directions, each separated by 45o angles. Therefore anything larger than a 22.5o projection rotation (usually only violated in parts of the domain) means that the wind components are using the wrong topographic directional information. For the determined user, the namelist variable max_rot_angle_gwd = 100 (really, anything greater than 90o) will always permit GWD to be used, regardless of the projection. How to estimate that the domain will or will not work within the 22.5o restriction: Only be concerned with d01 If the pole is in the domain AND this is not a global projection - the domain will not work Look at the SINALPHA field from metgrid (SINA field from wrfinput). SIN(22.5o) = 0.38. If the SINALPHA (or SINA) field has values greater than 0.38, the WRF model will gracefully stop. Internal to the code, if the projection angle > 22.5o, the model stops. A regular lat/lon or a Mercator projection will always work LIST OF MODIFIED FILES: M dyn_em/start_em.F M Registry/Registry.EM_COMMON TESTS CONDUCTED: Reggie 3.07, passed Test GSD RAP domain - it does not allow gwd_opt=1 Max projection rotation angle for domain 1 = 90.00 This projection may not be appropriate for using the gravity wave drag option. In namelist.input make one of the two following changes: 1) gwd_opt = 0 2) max_rot_angle_gwd > 90.00 -------------- FATAL CALLED --------------- FATAL CALLED FROM FILE: <stdin> LINE: 196 --- ERROR: gwd_opt does not work with this domain ------------------------------------------- For a domain above the pole, to use gwd_opt=1 NO MATTER WHAT: &dynamics gwd_opt = 1 max_rot_angle_gwd = 100 /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: new feature
KEYWORDS: gwd_opt, projection
SOURCE: internal
DESCRIPTION OF CHANGES:
Assume that the user is trying to use gravity wave drag (GWD), gwd_opt=1 in the ARW model. For domain 1, if the projection has a large rotation angle anywhere within the domain ("rotation" is directly from the sina variable in the WRF input and output, and "large" means greater than a default value of 22.5 degrees), notify the user and stop. The original GWD data has information at 45 degree angles. Therefore anything larger than a 22.5 degree projection rotation (usually only violated in parts of the domain) means that the wind components are using the wrong topographic directional information.
For the determined user, the namelist variable max_rot_angle_gwd = 100 (really, anything greater than 90) will always permit GWD to be used, regardless of the projection.
How to estimate that the domain will or will not work within the 22.5 degree restriction:
LIST OF MODIFIED FILES:
M dyn_em/start_em.F
TESTS CONDUCTED:
For a domain above the pole, to use gwd_opt=1 NO MATTER WHAT: