Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pxlsm lcz61 ii #2023

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Pxlsm lcz61 ii #2023

merged 1 commit into from
Mar 27, 2024

Conversation

coastwx
Copy link
Contributor

@coastwx coastwx commented Mar 19, 2024

Pleim-Xiu LSM MODIS LCZ Compatibility & Surface Evaporation Update

TYPE: bug fix & physics refinement

KEYWORDS: MODIS, LCZ, P-X LSM, Latent Heat Flux

SOURCE: Robert Gilliam & Jon Pleim, US EPA

DESCRIPTION OF CHANGES:
Problem:

  1. User indicated that the P-X LSM errored for MODIS LCZ 61 NUM_LAND_CAT configuration.
  2. Currently, we account for evaporation from transpiration, soil in both vegetated and non-veg parts, and wet leaves. But we only account for the latent heat effects on Tg from transpiration and evaporation from non-veg soil.
    This fix adds latent heat effects on Tg from soil in vegetated parts and from wet leaves.
  3. Fix for rare case where GRDFLX goes NaN because of a divide by zero based on a soil parameter when a water cell turns to sea ice.

Solution:
Logic checks in module_physics_init.F and module_sf_pxlsm.F were adjusted for 61 category inputs. P-X LSM data table, module_sf_pxlsm_data.F was updated for MODIS 61 categories. Default for LCZ 51-61 was set to MODIS urban class. We also added updates for the evaporation from vegetation and wet canopy.

ISSUE:
Fixes: #1965

LIST OF MODIFIED FILES:
M phys/module_physics_init.F
M phys/module_sf_pxlsm.F
M phys/module_sf_pxlsm_data.F

TESTS CONDUCTED:

  • Tested 61 class LCZ with PX LSM for a 1 day simulation with updated codes. Ran base MODIS 21 class scheme with same code before and after LCZ update. The results were identical after a 24 hour simulation. This confirms updates do not impact other MODIS settings in the P-X LSM. The MODIS 21 was by nature not identical to the MODIS 61, but similar enough and differences follow underlying differences in MODIS datasets.

Followed with another longer July 2018 test of the update surface evaporation in the P-X LSM.
image

  • The Jenkins tests are all passing.

RELEASE NOTE:
Pleim-Xiu LSM is now compatible with 61 category MODIS LCZ landuse dataset. A mode of latent heat effects on Tg from vegetated parts and from wet leaves is added to Pleim-Xiu LSM.

@weiwangncar weiwangncar changed the base branch from master to develop March 19, 2024 17:13
@weiwangncar
Copy link
Collaborator

@coastwx Did you decide not to add RA, RS and LANDUSEF to the history output?

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@coastwx
Copy link
Contributor Author

coastwx commented Mar 20, 2024

Thanks Wei. Looks like it passed the testing.

With the reservations of adding RA and RS and sensitivity to other user's default output size, I just left the registry out of the pull request. Also thought about LANDUSEF more. Since our domains are static, this can be used from other inputs. MCIP that processes WRF for CMAQ has an option to use the geogrid file for these geographical data inputs. RA and RS are different obviously, but sensitive to other users. We plan to update the P-X LSM run notes documentation with the other method of using text file to remove and add variables to the output. This is preferable anyhow because we can reduce the output size a lot. I'll pass along that updated document if NCAR is willing to replace the one hosted now.

@weiwangncar
Copy link
Collaborator

@coastwx That works with us. Thanks!

@dudhia
Copy link
Collaborator

dudhia commented Mar 20, 2024 via email

@coastwx
Copy link
Contributor Author

coastwx commented Mar 20, 2024 via email

Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve it. I mentioned it to @cenlinhe but I think it is OK.

@weiwangncar weiwangncar merged commit b7f31dc into wrf-model:develop Mar 27, 2024
1 of 16 checks passed
@coastwx
Copy link
Contributor Author

coastwx commented Mar 28, 2024

Super. Thanks Wei and Jimy for the advice and consultation.

@coastwx coastwx deleted the PXLSM_LCZ61_II branch March 28, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lcz cant use sf_surface_physics=7?
3 participants