-
Notifications
You must be signed in to change notification settings - Fork 817
Fixing typographic errors in the WRFDA code #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d22441
Fixing some typos in WRFDA code
mkavulich 04d0151
Fixing more typos in WRFDA code
mkavulich 6aff1b7
Based on pull request comments, fixing persistent typo in several fil…
mkavulich 70230b5
Another round of typo fixes from pull request comments, thanks Jamie
mkavulich 0f8c25c
Reverting changes based on pull request feedback
mkavulich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are zillions of British spellings of initialisation within DA. I'd say leave these alone. Here's a grep in the var directory ...
find . -name *.inc -exec grep -i initialis {} ; -print > foo.txt
! Initialise columns k+1:n to columns of the unit matrix
./external/lapack/dorg2r.inc
! Initialise columns 1:n-k to columns of the unit matrix
./external/lapack/dorg2l.inc
! [1.0]: Initialise:
./da/da_tools/da_1d_eigendecomposition.inc
! [1.0] Initialise components of innovation vector:
./da/da_obs/da_setup_pseudo_obs.inc
! Initialise obs error factors (which will be overwritten in use_obs_errfac)
./da/da_obs/da_fill_obs_structures.inc
! Initialise obs error factors (which will be overwritten in use_obs_errfac)
./da/da_obs/da_fill_obs_structures_rain.inc
! [1.0] Initialise random number sequence:
./da/da_obs/da_random_omb_all.inc
! Initialise obs error factors (which will be overwritten in use_obs_errfac)
./da/da_obs/da_fill_obs_structures_radar.inc
! [2.0] Initialise components of innovation vector:
./da/da_ssmi/da_get_innov_vector_ssmt1.inc
! [3.0] Calculate rv, rf at OBS location and initialise components of &
./da/da_radar/da_get_innov_vector_radar.inc
! [2.0] Initialise components of innovation vector:
./da/da_rain/da_get_innov_vector_rain.inc
! [1.0] Initialise bins:
./da/da_statistics/da_data_distribution.inc
! [1.0] Initialise:
./da/da_define_structures/da_allocate_background_errors.inc
! Purpose: Initialises the Y-array
./da/da_define_structures/da_zero_y.inc
! [2.0] Initialise components of innovation vector:
./da/da_sound/da_get_innov_vector_sound.inc
! [1.0] Initialise:
./da/da_recursive_filter/da_recursive_filter_1d_adj.inc
! [1.0]: Initialise:
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf_adj_dual_res.inc
! [1.0]: Initialise:
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf_adj.inc
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf_dual_res.inc
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf.inc
! [1.0]: Initialise:
./da/da_recursive_filter/da_calculate_rf_factors.inc
! [1.0] Initialise:
./da/da_recursive_filter/da_apply_rf_1v.inc
! [1.0] Initialise:
./da/da_recursive_filter/da_recursive_filter_1d.inc
! [2.0] Initialise components of innovation vector:
./da/da_tamdar/da_get_innov_vector_tamdar.inc
! [1.0] Initialise:
./da/da_setup_structures/da_get_vertical_truncation.inc
! 5.0 Initialise control variable space components of header:
./da/da_setup_structures/da_setup_be_regional.inc
! [1.0] Initialise:
./da/da_setup_structures/da_rescale_background_errors.inc
! 4.0 Initialise control variable space components of header:
./da/da_setup_structures/da_setup_be_nmm_regional.inc
! [1.0] Initialise:
./da/da_test/da_check_cvtovv_adjoint.inc
! [1.0] Initialise:
./da/da_test/da_check_vvtovp_adjoint.inc
! [1.0] Initialise:
./da/da_test/da_check_vtox_adjoint.inc
! [1.0]: Initialise:
./da/da_test/da_check_balance.inc
! [1.0] Initialise:
./da/da_test/da_check_xtoy_adjoint.inc
! [1.0]: initialise:
./da/da_test/da_setup_testfield.inc
! [1.0] Initialise:
./da/da_test/da_check_vptox_adjoint.inc
! initialise index:
./da/da_tracing/da_trace_int_sort.inc
! Purpose: Initialise tracing
./da/da_tracing/da_trace_init.inc
! initialise index:
./da/da_tracing/da_trace_real_sort.inc
! [2.0] Initialise components of innovation vector:
./da/da_mtgirs/da_get_innov_vector_mtgirs.inc
! [2.0] Initialise wrfvar parameters:
./da/da_main/da_solve.inc
! [2.0] Initialise components of innovation vector:
./da/da_profiler/da_get_innov_vector_profiler.inc
! [2.0] Initialise components of innovation vector:
./da/da_pilot/da_get_innov_vector_pilot.inc
! [2.0] Initialise components of innovation vector:
./da/da_bogus/da_get_innov_vector_bogus.inc
! [2.0] Initialise components of innovation vector:
./da/da_airsr/da_get_innov_vector_airsr.inc
! [2.0] Initialise components of innovation vector:
./da/da_airep/da_get_innov_vector_airep.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fct.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fct_adj.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fst_adj.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fst.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_iasi.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_airs.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_hirs.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_atms.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_mwts.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_seviri.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_amsua.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_amsr2.inc
! 0.0 initialise QC flags by assuming good obs
./da/da_radiance/da_qc_mwhs.inc
! 0.0 initialise QC flags by assuming good obs
./da/da_radiance/da_qc_mhs.inc
gooddata_map(i,j) = .TRUE. ! Initialised for step 6)
./da/da_radiance/ATMS_Spatial_Average.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_ssmis.inc
! 0.0 initialise QC flags by assuming good obs
./da/da_radiance/da_qc_amsub.inc
x = 0.5*(x1 + x2) ! Initialise the guess for the root
./da/da_spectral/da_get_gausslats.inc
! Initialise Power spectrum
./da/da_spectral/da_test_spectral.inc
! Initialise the varibles
./da/da_gpspw/da_transform_xtoy_gpsztd_adj.inc
! Initialise the varibles
./da/da_gpspw/da_transform_xtoy_gpspw_adj.inc
! [1.0]: Initialise:
./da/da_vtox_transforms/da_check_eof_decomposition.inc
! [1.0] Initialise:
./da/da_vtox_transforms/da_transform_bal.inc
! [1.0] Initialise:
./da/da_vtox_transforms/da_transform_bal_adj.inc
! [2.0] Initialise components of innovation vector:
./da/da_metar/da_get_innov_vector_metar.inc
! [1.0] Initialise:
./da/da_dynamics/da_wpec_constraint_adj.inc
! [1.0] Initialise i and set multiplicative constants
./da/da_dynamics/da_wpec_constraint.inc
! [1.0] Initialise i and set multiplicative constants
./da/da_dynamics/da_wpec_constraint_lin.inc
! [1.0] Initialise:
./da/da_dynamics/da_uv_to_divergence.inc
! [1.0] Initialise iand set Multipilactive constants
./da/da_dynamics/da_balance_equation_lin.inc
! [1.0] Initialise:
./da/da_dynamics/da_wpec_constraint_geoterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_uv_to_divergence_adj.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_cycloterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_wpec_constraint_cycloterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_uv_to_vorticity.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_cycloterm_lin.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_equation_adj.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_geoterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_cycloterm_adj.inc
! [1.0] initialise:
./da/da_physics/da_tp_to_qs.inc
! [1.0] initialise:
./da/da_physics/da_tp_to_qs_lin1.inc
! [1.0] initialise:
./da/da_physics/da_tprh_to_q_adj.inc
! [1.0] initialise:
! [1.0] initialise:
./da/da_physics/da_tp_to_qs1.inc
! [1.0] initialise:
./da/da_physics/da_prho_to_t_adj.inc
! [1.0] initialise:
./da/da_physics/da_tp_to_qs_adj.inc
! Purpose: Initialises the Y-array
./da/da_minimisation/da_calculate_j.inc
! [2.0] Initialise components of innovation vector:
./da/da_qscat/da_get_innov_vector_qscat.inc
! [4.0] Allocate and initialise residual structure:
./obsproc/MAP_plot/Dir_map/DA_Setup_Obs_Structures.inc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davegill I changed that one because in the beginning of that same subroutine (a few lines earlier) the American spelling is used. But I can leave this one alone I guess.