Skip to content

Improved ignores#1978

Merged
islas merged 4 commits intowrf-model:developfrom
islas:improvedIgnores
Jan 9, 2024
Merged

Improved ignores#1978
islas merged 4 commits intowrf-model:developfrom
islas:improvedIgnores

Conversation

@islas
Copy link
Collaborator

@islas islas commented Jan 6, 2024

TYPE: enhancement

KEYWORDS: ignores

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Many files are generated in the repo's directories and should be ignored to avoid accidental addition to commits.

Solution:
Ignore known file patterns

LIST OF MODIFIED FILES:
M .gitignore

TESTS CONDUCTED:
No impact

RELEASE NOTE:
Improved set of ignores

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@mgduda mgduda self-requested a review January 8, 2024 22:39
Copy link
Collaborator

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me.

@islas islas merged commit ff4f6d6 into wrf-model:develop Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants