BUG FIX: chem_opt = 201, 202 ph_diag#1813
Merged
weiwangncar merged 1 commit intowrf-model:developfrom Jan 31, 2023
Merged
Conversation
…chem_opts = 201 (MOZART_MOSAIC_4BIN_KPP) and 202 (MOZART_MOSAIC_4BIN_AQ_KPP). Users will experience a stalled simulation upon writing history files. This was caused by the pH diagnostics added in v4.3 not being activated with the namelist option mozart_ph_diag = 1. To remedy, the packaged arrays are only initialized and filled if this option is set.
ravanah
approved these changes
Jan 27, 2023
Collaborator
|
The Jenkins test results: |
weiwangncar
approved these changes
Jan 28, 2023
Collaborator
|
@jordanschnell Let me know if the change to the PR message looks ok to you. |
Contributor
Author
Yes, fine with me thanks. |
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…RT_MOSAIC_4BIN_KPP) and 202 (MOZART_MOSAIC_4BIN_AQ_KPP). (wrf-model#1813) Fixed a bug for chem_opt = 201, 202. TYPE: bug fix KEYWORDS: MOZART_MOSAIC_4BIN, mozart_pH_diag, bug fix SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Users will experience a stalled simulation upon writing history files. This was caused by the pH diagnostics added in v4.3 (wrf-model#1342) not being activated with the namelist option mozart_ph_diag = 1. Solution: Add as optional arguments only filled if the namelist is activated. LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list) M chem/aerosol_driver.F M chem/cloudchem_driver.F M chem/module_mosaic_cloudchem.F M chem/module_mosaic_driver.F M chem/module_mosaic_therm.F TESTS CONDUCTED: Yes, the fix remedies the problem. The Jenkins tests have passed. RELEASE NOTE: This PR addresses a bug introduced in WRF v4.3 that affects users using chem_opts = 201 (MOZART_MOSAIC_4BIN_KPP) and 202 (MOZART_MOSAIC_4BIN_AQ_KPP).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug for chem_opt = 201, 202.
TYPE: bug fix
KEYWORDS: MOZART_MOSAIC_4BIN, mozart_pH_diag, bug fix
SOURCE: Internal
DESCRIPTION OF CHANGES:
Problem:
Users will experience a stalled simulation upon writing history files. This was caused by the pH diagnostics added in v4.3 (#1342) not being activated with the namelist option mozart_ph_diag = 1.
Solution:
Add as optional arguments only filled if the namelist is activated.
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)M chem/aerosol_driver.F
M chem/cloudchem_driver.F
M chem/module_mosaic_cloudchem.F
M chem/module_mosaic_driver.F
M chem/module_mosaic_therm.F
TESTS CONDUCTED:
RELEASE NOTE: This PR addresses a bug introduced in WRF v4.3 that affects users using chem_opts = 201 (MOZART_MOSAIC_4BIN_KPP) and 202 (MOZART_MOSAIC_4BIN_AQ_KPP).