Bug fix for chem DA omb/oma output#1718
Merged
liujake merged 3 commits intowrf-model:release-v4.4from Apr 20, 2022
Merged
Conversation
modified: var/da/da_obs_io/da_read_omb_tmp.inc
Collaborator
|
Jenkins tests have passed: |
syha
approved these changes
Apr 19, 2022
Contributor
syha
left a comment
syha
left a comment
There was a problem hiding this comment.
It seems to be working for me now.
Contributor
Author
|
@weiwangncar can you approve this after Jenkins pass. so that I can merge with two approvals? |
junmeiban
approved these changes
Apr 20, 2022
Collaborator
|
@liujake I had not approved this PR because I have not received the test results from your last commit made at 4:43. |
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: Chem DA, OMB/OMA SOURCE: Jake Liu (NCAR/MMM) DESCRIPTION OF CHANGES: Problem: PR wrf-model#1575 breaks ChemDA's omb/oma output. Solution: Make write/read omb/oma format consistent LIST OF MODIFIED FILES: M var/da/da_obs_io/da_final_write_obs_gas_sfc.inc M var/da/da_obs_io/da_read_omb_tmp.inc M. var/da/da_obs_io/da_write_obs_chem_sfc.inc TESTS CONDUCTED: Tested mosaic scheme with chemicda_opt = 1,2,3,4, or 5. RELEASE NOTE: None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: Chem DA, OMB/OMA
SOURCE: Jake Liu (NCAR/MMM)
DESCRIPTION OF CHANGES:
Problem:
PR #1575 breaks ChemDA's omb/oma output.
Solution:
Make write/read omb/oma format consistent
LIST OF MODIFIED FILES:
M var/da/da_obs_io/da_final_write_obs_gas_sfc.inc
M var/da/da_obs_io/da_read_omb_tmp.inc
M. var/da/da_obs_io/da_write_obs_chem_sfc.inc
TESTS CONDUCTED:
Tested mosaic scheme with chemicda_opt = 1,2,3,4, or 5.
RELEASE NOTE: None.