BF: WRF-Solar EPS broke DA build#1655
Merged
davegill merged 1 commit intowrf-model:developfrom Jan 25, 2022
Merged
Conversation
TYPE: bug fix KEYWORDS: EPS, DA SOURCE: internal DESCRIPTION OF CHANGES: Problem: The WRF-Solar EPS mods (PR wrf-model#1547, SHA1 fed10f4) modified the solve_em.F file, with arguments to the microphysics driver. The solver_em.F file is one of the special files that has a _ad and a _tl version. Any changes to solve_em.F need to be reflected in the other two DA-related files. Solution: In this case, since only Thompson MP uses the EPS fields, the new args were made optional in the MP driver. LIST OF MODIFIED FILES: M phys/module_microphysics_driver.F TESTS CONDUCTED: 1. Yes, code compiles and passes regtests.
weiwangncar
approved these changes
Jan 25, 2022
dudhia
approved these changes
Jan 25, 2022
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: EPS, DA SOURCE: internal DESCRIPTION OF CHANGES: Problem: The WRF-Solar EPS mods (PR wrf-model#1547, SHA1 fed10f4) modified the solve_em.F file, with arguments to the microphysics driver. The solver_em.F file is one of the special files that has a _ad and a _tl version. Any changes to solve_em.F need to be reflected in the other two DA-related files. Solution: In this case, since only Thompson MP uses the EPS fields, the new args were made optional in the MP driver. LIST OF MODIFIED FILES: M phys/module_microphysics_driver.F TESTS CONDUCTED: 1. Yes, code compiles and passes regtests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: EPS, DA
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The WRF-Solar EPS mods (PR #1547, SHA1 fed10f4) modified the solve_em.F file, with
arguments to the microphysics driver. The solver_em.F file is one of the special files
that has a _ad and a _tl version. Any changes to solve_em.F need to be reflected in the
other two DA-related files.
Solution:
In this case, since only Thompson MP uses the EPS fields, the new args were made optional in
the MP driver.
LIST OF MODIFIED FILES:
M phys/module_microphysics_driver.F
TESTS CONDUCTED: