Skip to content

Update HONO, TERP, and CO2 emissions#1644

Merged
davegill merged 1 commit intowrf-model:developfrom
rschwant:develop_anthro_emiss_racm
Jan 19, 2022
Merged

Update HONO, TERP, and CO2 emissions#1644
davegill merged 1 commit intowrf-model:developfrom
rschwant:develop_anthro_emiss_racm

Conversation

@rschwant
Copy link
Contributor

@rschwant rschwant commented Jan 18, 2022 •
edited by davegill
Loading

TYPE: enhancement

KEYWORDS: anthropogenic emissions

SOURCE: Rebecca Schwantes (CIRES/NOAA CSL)

DESCRIPTION OF CHANGES:
Update code to add HONO, TERP, and CO2 anthropogenic emissions for RACM mechanisms.

Problem:
HONO, TERP, and CO2 anthropogenic emissions were not automatically pulled into the RACM mechanisms.

Solution:
Added some if statements such that if HONO, TERP, and CO2 are in the anthropogenic emission file and hono,
api, lim, and co2 are chemical species in the selected RACM mechanism, then the HONO, TERP, and CO2
anthropogenic emissions would be included in the simulation.

LIST OF MODIFIED FILES:
M Registry/registry.chem
M chem/module_emissions_anthropogenics.F

TESTS CONDUCTED:

  1. The modifications fix the problem of missing (but available) anthropogenic emissions.
  2. jenkins tests are all passing.
  3. Attached are some plots that show that with the updates HONO, CO2, API, and LIM now all increase in regions impacted by anthropogenic emissions (namely you can clearly see increases in cities) compared to the default case.

anthropogenic_emission_quick_QC.pdf

RELEASE NOTE: Previously, HONO, TERP, and CO2 were not automatically pulled into the RACM mechanisms even when they were in the anthropogenic emissions file. This has been fixed.

@rschwant rschwant requested a review from a team as a code owner January 18, 2022 15:47
@davegill
Copy link
Contributor

davegill commented Jan 18, 2022

@rschwant
Rebecca,
Is there a simple before vs after plot, or before vs after printout that shows the availability and usage of these anthropogenic emissions?

@rschwant
Copy link
Contributor Author

rschwant commented Jan 18, 2022

Good question. I was comparing to an older version, but I'm sure you want a clean compare with the current develop branch. Let me run this quickly and I'll make you a cleaner plot hopefully by tomorrow. Thanks!

@davegill
Copy link
Contributor

davegill commented Jan 18, 2022

@rschwant
Rebecca,
Take a look at the PR message for #1625
We just want something SIMPLE that we can point to that says "ah ha, it does do what was said".

@rschwant
Copy link
Contributor Author

rschwant commented Jan 19, 2022

I attached some plots that show that with the updates HONO, CO2, API, and LIM now all increase in regions impacted by anthropogenic emissions (namely you can clearly see increases in cities) compared to the default case. Let me know if you have any questions. Thanks!

anthropogenic_emission_quick_QC.pdf

jordanschnell
jordanschnell approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@jordanschnell jordanschnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by /chem

@davegill davegill merged commit 96fd889 into wrf-model:develop Jan 19, 2022
davegill added a commit that referenced this pull request Jan 24, 2022
@davegill
BF: NETCDFPAR "Error" in build log when option not used (#1651)
a2ad00c 
TYPE: bug fix

KEYWORDS: netcdfpar, Error

SOURCE: internal

DESCRIPTION OF CHANGES:
IMPORTANT: Without these mods, every commit since the parallel netcdf4 IO mods will fail the DA
build test in the regression test. For example, at least these commits:
```
fed10f4 Adding the WRF-Solar EPS model (#1547)
0bda5e0 Fix 4dvar build failure after commit 8b5bfe5 (#1652)
8b5bfe5 Thompson AA enhancements: BC aerosol, biomass burning emissions, and … (#1616)
9dc68ca After testing with UFS/GFS/FV-3, some tuning knob changes to Thompson-MP and icloud3 (cloud fraction) scheme (#1626)
96fd889 Update HONO, TERP, and CO2 emissions (#1644)
64fb190 SFCLAY=1, add shallow water roughness calculation (#1543)
609c2fc New module firebrand_spotting for WRF-Fire (#1540)
75bfe6d MYNN PBL clouds in photolysis option 4 (TUV) (#1622)
f8c4b13 Fix runtime error when using sf_surface_mosaic = 1 with use_wudapt_lcz = 0 (#1638)
b511c70 Run-time option for climate GHG for radiation (#1625)
8194c66 Bug fix for configuration option INTEL:HSW/BDW (#1645)
16c9287  bug fixes for radar_rf_opt=2 (#1642)
a82ce24 Sync with NoahMP Github version with all NoahMP updates since v4.3 (#1641)
7b642cc Bug fix for TAMDAR T VarBC (#1632)
92fd706 fix WRFDA build for Parallel netcdf-4 IO (#1634)
```
Problem:
With PR #1552 "Parallel netcdf-4 IO option" (SHA1 3cd4713), when then code was built without
the new parallel NetCDF4 compression, the build log had an `Error`. 
```
> grep Error compile.log
Fatal Error: Cannot open module file ‘wrf_data_ncpar.mod’ for reading at (1): No such file or directory
make[2]: [diffwrf] Error 1 (ignored)
make[2]: [diffwrf] Error 1 (ignored)
wrf_io.f:117: Error: Can't open included file 'mpif.h'
make[2]: [wrf_io.o] Error 1 (ignored)
Fatal Error: Cannot open module file ‘wrf_data_ncpar.mod’ for reading at (1): No such file or directory
make[2]: [field_routines.o] Error 1 (ignored)
make[2]: [libwrfio_nfpar.a] Error 127 (ignored)
make[2]: [libwrfio_nfpar.a] Error 1 (ignored)
```
The problem was related to constructing the object files in the io_netcdfpar directory. When the 
option is not selected at compile time, then we do not care about errors in the directory that will 
never be used.

Solution:
If the NETCDFPAR option is not selected at compile time, then SKIP going into the io_netcdfpar
directory all together.

LIST OF MODIFIED FILES:
m Makefile
m arch/Config.pl
m arch/configure.defaults
m configure

TESTS CONDUCTED:
1. Without the NETCDFPAR parameter set, the build for the io_netcdfpar directory is bypassed:
```
          cd ../io_netcdfpar ; \
          echo SKIPPING make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.7.3/gnu/9.1.0" \

          cd ../io_netcdfpar ; \
          echo SKIPPING make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.7.3/gnu/9.1.0" \
```

2. When the NETCDFPAR env variable is set, the build includes the io_netcdfpar directory:
          cd ../io_netcdfpar ; \
           make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.8.0/gnu/9.1.0" \

          cd ../io_netcdfpar ; \
           make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.8.0/gnu/9.1.0" \
```

3. Jenkins tests are all PASS.
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
@rschwant @vlakshmanan-scala
Update HONO, TERP, and CO2 emissions (wrf-model#1644)
4146cb6 
TYPE: enhancement

KEYWORDS: anthropogenic emissions

SOURCE: Rebecca Schwantes (CIRES/NOAA CSL)

DESCRIPTION OF CHANGES:
Update code to add HONO, TERP, and CO2 anthropogenic emissions for RACM mechanisms.

Problem:
HONO, TERP, and CO2 anthropogenic emissions were not automatically pulled into the RACM mechanisms.

Solution:
Added some if statements such that if HONO, TERP, and CO2 are in the anthropogenic emission file and hono, 
api, lim, and co2 are chemical species in the selected RACM mechanism, then the HONO, TERP, and CO2 
anthropogenic emissions would be included in the simulation.

LIST OF MODIFIED FILES: 
M Registry/registry.chem
M chem/module_emissions_anthropogenics.F

TESTS CONDUCTED: 
1. The modifications fix the problem of missing (but available) anthropogenic emissions.
2.  jenkins tests are all passing.
3. Attached are some plots that show that with the updates HONO, CO2, API, and LIM now all increase in regions impacted by anthropogenic emissions (namely you can clearly see increases in cities) compared to the default case.

[anthropogenic_emission_quick_QC.pdf](https://github.com/wrf-model/WRF/files/7900930/anthropogenic_emission_quick_QC.pdf)

RELEASE NOTE: Previously, HONO, TERP, and CO2 were not automatically pulled into the RACM mechanisms even when they were in the anthropogenic emissions file. This has been fixed.
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
@davegill @vlakshmanan-scala
BF: NETCDFPAR "Error" in build log when option not used (wrf-model#1651)
3e231d4 
TYPE: bug fix

KEYWORDS: netcdfpar, Error

SOURCE: internal

DESCRIPTION OF CHANGES:
IMPORTANT: Without these mods, every commit since the parallel netcdf4 IO mods will fail the DA
build test in the regression test. For example, at least these commits:
```
fed10f4 Adding the WRF-Solar EPS model (wrf-model#1547)
0bda5e0 Fix 4dvar build failure after commit 8b5bfe5 (wrf-model#1652)
8b5bfe5 Thompson AA enhancements: BC aerosol, biomass burning emissions, and … (wrf-model#1616)
9dc68ca After testing with UFS/GFS/FV-3, some tuning knob changes to Thompson-MP and icloud3 (cloud fraction) scheme (wrf-model#1626)
96fd889 Update HONO, TERP, and CO2 emissions (wrf-model#1644)
64fb190 SFCLAY=1, add shallow water roughness calculation (wrf-model#1543)
609c2fc New module firebrand_spotting for WRF-Fire (wrf-model#1540)
75bfe6d MYNN PBL clouds in photolysis option 4 (TUV) (wrf-model#1622)
f8c4b13 Fix runtime error when using sf_surface_mosaic = 1 with use_wudapt_lcz = 0 (wrf-model#1638)
b511c70 Run-time option for climate GHG for radiation (wrf-model#1625)
8194c66 Bug fix for configuration option INTEL:HSW/BDW (wrf-model#1645)
16c9287  bug fixes for radar_rf_opt=2 (wrf-model#1642)
a82ce24 Sync with NoahMP Github version with all NoahMP updates since v4.3 (wrf-model#1641)
7b642cc Bug fix for TAMDAR T VarBC (wrf-model#1632)
92fd706 fix WRFDA build for Parallel netcdf-4 IO (wrf-model#1634)
```
Problem:
With PR wrf-model#1552 "Parallel netcdf-4 IO option" (SHA1 3cd4713), when then code was built without
the new parallel NetCDF4 compression, the build log had an `Error`. 
```
> grep Error compile.log
Fatal Error: Cannot open module file ‘wrf_data_ncpar.mod’ for reading at (1): No such file or directory
make[2]: [diffwrf] Error 1 (ignored)
make[2]: [diffwrf] Error 1 (ignored)
wrf_io.f:117: Error: Can't open included file 'mpif.h'
make[2]: [wrf_io.o] Error 1 (ignored)
Fatal Error: Cannot open module file ‘wrf_data_ncpar.mod’ for reading at (1): No such file or directory
make[2]: [field_routines.o] Error 1 (ignored)
make[2]: [libwrfio_nfpar.a] Error 127 (ignored)
make[2]: [libwrfio_nfpar.a] Error 1 (ignored)
```
The problem was related to constructing the object files in the io_netcdfpar directory. When the 
option is not selected at compile time, then we do not care about errors in the directory that will 
never be used.

Solution:
If the NETCDFPAR option is not selected at compile time, then SKIP going into the io_netcdfpar
directory all together.

LIST OF MODIFIED FILES:
m Makefile
m arch/Config.pl
m arch/configure.defaults
m configure

TESTS CONDUCTED:
1. Without the NETCDFPAR parameter set, the build for the io_netcdfpar directory is bypassed:
```
          cd ../io_netcdfpar ; \
          echo SKIPPING make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.7.3/gnu/9.1.0" \

          cd ../io_netcdfpar ; \
          echo SKIPPING make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.7.3/gnu/9.1.0" \
```

2. When the NETCDFPAR env variable is set, the build includes the io_netcdfpar directory:
          cd ../io_netcdfpar ; \
           make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.8.0/gnu/9.1.0" \

          cd ../io_netcdfpar ; \
           make -i -r NETCDFPARPATH="/glade/u/apps/ch/opt/netcdf/4.8.0/gnu/9.1.0" \
```

3. Jenkins tests are all PASS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordanschnell jordanschnell jordanschnell approved these changes

Assignees

No one assigned

Labels

Develop Branch Enhancement WRF Chem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rschwant @davegill @jordanschnell