Closed
Conversation
SOURCE: internal, Doug Lowe (UK), Paolo Tuccella (Italy)
DESCRIPTION OF CHANGES:
1) registry.chem is changed to reduce the memory footprint and remove unused 3D arrays. Some commented lines have been removed from registry too.
2) Several modules are changed so chemistry option RACM_SOA_VBS_AQCHEM_KPP (chem_opt=109) works properly. These fixes are mostly related to CASE statements for the RACM_SOA_VBS_AQCHEM_KPP option.
LIST OF MODIFIED FILES:
modified: ../Registry/registry.chem
modified: ../chem/aerosol_driver.F
modified: ../chem/chemics_init.F
modified: ../chem/cloudchem_driver.F
modified: ../chem/module_bioemi_megan2.F
TESTS CONDUCTED: Code has been compiled and run successfully on NOAA HPC. The regression test is in progress.
jamiebresch
reviewed
Mar 4, 2017
|
|
||
| # Diagnostic packages for the SOA schemes | ||
| package diag_vbs diagnostic_soa==108 - state:br_rto | ||
|
|
Contributor
There was a problem hiding this comment.
The changes related to diagnostic_soa (here and new line 3767) look suspicious to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fixes
SOURCE: internal, Doug Lowe (UK), Paolo Tuccella (Italy)
DESCRIPTION OF CHANGES:
1) registry.chem is changed to reduce the memory footprint and remove unused 3D arrays. Some commented lines have been removed from registry too.
2) Several modules are changed so chemistry option RACM_SOA_VBS_AQCHEM_KPP (chem_opt=109) works properly. These fixes are mostly related to CASE statements for the RACM_SOA_VBS_AQCHEM_KPP option.
LIST OF MODIFIED FILES:
modified: ../Registry/registry.chem
modified: ../chem/aerosol_driver.F
modified: ../chem/chemics_init.F
modified: ../chem/cloudchem_driver.F
modified: ../chem/module_bioemi_megan2.F
TESTS CONDUCTED: The WRF-Chem code has been compiled and run successfully on NOAA HPC. The regression test is in progress.