Put KIAPS rad LW back to original#1612
Merged
davegill merged 1 commit intowrf-model:developfrom Dec 21, 2021
Merged
Conversation
TYPE: bug fix KEYWORDS: KIAPS, radiation, LW SOURCE: internal DESCRIPTION OF CHANGES: Problem: In an attempt to get the KIAPS radiation LW scheme to build with older GNU compilers, some simplifications were introduced to remove ONLY clauses. However, an error was introduced - a module from RRTMG was "USEd" (hash 911b845 introduced some simplifcations and the error, hash a83c7cb tried to fix the error in the wrong way). Solution: Put the entire KIAPS radiation LW scheme back to the original pristine condition, as the current GNU compilers have no troubles with building the scheme. And fix that bug! LIST OF MODIFIED FILES: TESTS CONDUCTED: 1. GNU builds the original KIAPS LW radiation scheme. 2. Jenkins is all PASS. RELEASE NOTE: An error was introduced into the KIAPS LW radiation scheme. This problem tried to fix a compilation failure, and ended up introducing yet another compile-time failure. The solution is to revert the entire KIAPS LW radiation scheme to the original pristine condition.
Contributor
Author
|
@weiwangncar @smileMchen |
davegill
commented
Dec 21, 2021
weiwangncar
approved these changes
Dec 21, 2021
smileMchen
approved these changes
Dec 21, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: KIAPS, radiation, LW SOURCE: internal DESCRIPTION OF CHANGES: Problem: In an attempt to get the KIAPS radiation LW scheme to build with older GNU compilers, some simplifications were introduced to remove ONLY clauses. However, an error was introduced - a module from RRTMG was "USEd" (hash 911b845 introduced some simplifications and the error, hash a83c7cb tried to fix the error in the wrong way). Solution: Put the entire KIAPS radiation LW scheme back to the original pristine condition, as the current GNU compilers have no troubles with building the scheme. And fix that bug! LIST OF MODIFIED FILES: TESTS CONDUCTED: 1. GNU builds the original KIAPS LW radiation scheme. 2. Jenkins is all PASS. RELEASE NOTE: An error was introduced into the KIAPS LW radiation scheme. This problem tried to fix a compilation failure, and ended up introducing yet another compile-time failure. The solution is to revert the entire KIAPS LW radiation scheme to the original pristine condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: KIAPS, radiation, LW
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
In an attempt to get the KIAPS radiation LW scheme to build with older GNU compilers,
some simplifications were introduced to remove ONLY clauses. However, an error was
introduced - a module from RRTMG was "USEd" (hash 911b845 introduced some
simplifications and the error, hash a83c7cb tried to fix the error in the
wrong way).
Solution:
Put the entire KIAPS radiation LW scheme back to the original pristine condition, as the
current GNU compilers have no troubles with building the scheme. And fix that bug!
LIST OF MODIFIED FILES:
TESTS CONDUCTED:
RELEASE NOTE: An error was introduced into the KIAPS LW radiation scheme. This problem
tried to fix a compilation failure, and ended up introducing yet another compile-time
failure. The solution is to revert the entire KIAPS LW radiation scheme to the original
pristine condition.