Adding accumulated GHI and fixing registry units for solar diagnostics package#1610
Merged
davegill merged 3 commits intowrf-model:developfrom Dec 24, 2021
Merged
Conversation
davegill
reviewed
Dec 20, 2021
davegill
reviewed
Dec 20, 2021
Contributor
|
@weiwangncar @twjuliano |
Collaborator
|
@davegill @twjuliano I'm ok with it. |
davegill
previously approved these changes
Dec 23, 2021
weiwangncar
reviewed
Dec 23, 2021
weiwangncar
reviewed
Dec 23, 2021
weiwangncar
approved these changes
Dec 24, 2021
davegill
approved these changes
Dec 24, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…s package (wrf-model#1610) TYPE: enhancement, bug fix KEYWORDS: WRF-Solar, diagnostics SOURCE: Timothy Juliano and Pedro Jimenez (NCAR/RAL) DESCRIPTION OF CHANGES: We have added a new 2D variable (`ghi_accum`) and time series variable (`ts_ghi_accum`) for the WRF-Solar diagnostics package. This variable uses `SWDNB` as computed by the radiation parameterization to accumulate downwelling GHI at the surface. The new variable is set to zero at the beginning of the simulation for either `restart=.true.` or `restart=.false.`. As a separate but very minor change, we have clarified units in the registry for cloud base and cloud height WRF-Solar variables. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M Registry/registry.solar_fields M dyn_em/start_em.F M phys/module_diag_solar.F M phys/module_diagnostics_driver.F M phys/module_physics_init.F M share/wrf_timeseries.F M run/README.tslist TESTS CONDUCTED: 1. Conducted test on Cheyenne to ensure that GHI is summed over time and set to zero properly at initialization for both 2D and time series variables. 2. All jenkins test are passing. RELEASE NOTE: A new variable that accumulates GHI over time is added to the WRF-Solar diagnostics package. Cloud base and cloud height units (AGL) are clarified in the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement, bug fix
KEYWORDS: WRF-Solar, diagnostics
SOURCE: Timothy Juliano and Pedro Jimenez (NCAR/RAL)
DESCRIPTION OF CHANGES:
We have added a new 2D variable (
ghi_accum) and time series variable (ts_ghi_accum) for the WRF-Solardiagnostics package. This variable uses
SWDNBas computed by the radiation parameterization to accumulatedownwelling GHI at the surface. The new variable is set to zero at the beginning of the simulation for either
restart=.true.orrestart=.false..As a separate but very minor change, we have clarified units in the registry for cloud base and cloud height
WRF-Solar variables.
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M Registry/registry.solar_fields
M dyn_em/start_em.F
M phys/module_diag_solar.F
M phys/module_diagnostics_driver.F
M phys/module_physics_init.F
M share/wrf_timeseries.F
M run/README.tslist
TESTS CONDUCTED:
both 2D and time series variables.
RELEASE NOTE: A new variable that accumulates GHI over time is added to the WRF-Solar diagnostics package. Cloud base and cloud height units (AGL) are clarified in the registry.