build module_state_description.F -> force zero return code#1601
Merged
davegill merged 1 commit intowrf-model:developfrom Dec 16, 2021
Merged
build module_state_description.F -> force zero return code#1601davegill merged 1 commit intowrf-model:developfrom
davegill merged 1 commit intowrf-model:developfrom
Conversation
TYPE: enhancement KEYWORDS: 255, return code, true SOURCE: internal DESCRIPTION OF CHANGES: Problem: When building the WRF model, one of the early steps is to use the registry program to construct a large number of include files, and to build the Fortran file module_state_description. This is constructing a Fortran file, not an executable. The return from that build is non-zero, and that causes a cascading failure on every AWS build, and (at least) many of the dual OS builds. Solution: We cheat. We add the the `true` command after the command that builds the file module_state_description.F. The return code from the whole process is then, voila, zero. LIST OF MODIFIED FILES: modified: frame/Makefile TESTS CONDUCTED: 1. Reproducibly, the build fails due to the non-zero return code for the build of the file module_state_description.F. ``` make[2]: [module_state_description.F] Error 255 ``` With the mod, the error code is magically zero. 2. Jenkins tests are all passing. RELEASE NOTE: The inclusion of the unix-y `true` command as the last command in a string of commands, now allows the WRF code to build on AWS with the Intel compiler. For other users, this will have no impact.
Contributor
Author
|
@kkeene44 @weiwangncar Wei, |
kkeene44
approved these changes
Dec 16, 2021
weiwangncar
approved these changes
Dec 16, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…1601) TYPE: enhancement KEYWORDS: 255, return code, true SOURCE: internal DESCRIPTION OF CHANGES: Problem: When building the WRF model, one of the early steps is to use the registry program to construct a large number of include files, and to build the Fortran file module_state_description. This is constructing a Fortran file, not an executable. The return from that build is non-zero, and that causes a cascading failure on every AWS build, and (at least) many of the dual OS builds. Solution: We cheat. We add the the `true` command after the command that builds the file module_state_description.F. The return code from the whole process is then, voila, zero. LIST OF MODIFIED FILES: modified: frame/Makefile TESTS CONDUCTED: 1. Reproducibly, the build fails due to the non-zero return code for the build of the file module_state_description.F. ``` make[2]: [module_state_description.F] Error 255 ``` With the mod, the error code is magically zero, and the WRF code builds without any issues. 2. Jenkins tests are all passing. RELEASE NOTE: After the inclusion of the unix-y `true` command as the last command in a string of registry-based commands, now the WRF code builds on AWS with the Intel compiler. For other users, this will have no impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: 255, return code, true
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
When building the WRF model, one of the early steps is to use the registry program to construct
a large number of include files, and to build the Fortran file module_state_description. This is
constructing a Fortran file, not an executable. The return from that build is non-zero, and that
causes a cascading failure on every AWS build, and (at least) many of the dual OS builds.
Solution:
We cheat. We add the the
truecommand after the command that builds the filemodule_state_description.F. The return code from the whole process is then, voila, zero.
LIST OF MODIFIED FILES:
modified: frame/Makefile
TESTS CONDUCTED:
module_state_description.F.
With the mod, the error code is magically zero, and the WRF code builds without any issues.
2. Jenkins tests are all passing.
RELEASE NOTE: After the inclusion of the unix-y
truecommand as the last command in a string of registry-based commands, now the WRF code builds on AWS with the Intel compiler. For other users, this will have no impact.