Another physics syntax error#1594
Merged
davegill merged 1 commit intowrf-model:release-v4.3.2from Dec 9, 2021
Merged
Conversation
TYPE: bug fix KEYWORDS: syntax, physics *+ SOURCE: Patricia Balle (HPE) DESCRIPTION OF CHANGES: Problem: As in hash 7c6fd57, PR wrf-model#1577 "Syntax errors in physics routines: *- and *+", there is a single remaining example of the unary operators next to each other. Solution: The author agreed that the `*+` combination was suppoed to be just `+`. LIST OF MODIFIED FILES: modified: phys/module_mp_ntu.F TESTS CONDUCTED: 1. Passes Cray compiler 2. Jenkins tests are OK
Contributor
Author
|
@smileMchen @kkeene44 |
Collaborator
|
@davegill |
Contributor
Author
|
@smileMchen |
Collaborator
|
@davegill |
smileMchen
approved these changes
Dec 9, 2021
kkeene44
approved these changes
Dec 9, 2021
Contributor
Author
|
@pkb99 |
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
) TYPE: bug fix KEYWORDS: syntax, physics, *+ SOURCE: Patricia Balle (HPE) DESCRIPTION OF CHANGES: Problem: As in hash 7c6fd57, PR wrf-model#1577 "Syntax errors in physics routines: *- and *+", there is a single remaining example of the unary operators next to each other. Solution: The author agreed that the `*+` combination was supposed to be just `+`. I searched the WRF code for instances of this `*+` in PR wrf-model#1577. When I did not find any, I put back one of them from NTU code to make sure that my grep was working. It found that example, and no others that I cared about. I forgot to undo that change before the `git add`, `git commit`. LIST OF MODIFIED FILES: modified: phys/module_mp_ntu.F TESTS CONDUCTED: 1. Passes Cray compiler. 2. Jenkins tests are OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: syntax, physics *+
SOURCE: Patricia Balle (HPE)
DESCRIPTION OF CHANGES:
Problem:
As in hash 7c6fd57, PR #1577 "Syntax errors in physics routines: *- and *+", there is a single
remaining example of the unary operators next to each other.
Solution:
The author agreed that the
*+combination was supposed to be just+.I searched the WRF code for instances of this
*+in PR #1577. When I did not find any, I put back one of them fromNTU code to make sure that my grep was working. It found that example, and no others that I cared about. I forgot
to undo that change before the
git add,git commit.LIST OF MODIFIED FILES:
modified: phys/module_mp_ntu.F
TESTS CONDUCTED: