Correct output variable name for CLM packaging#1589
Merged
davegill merged 1 commit intowrf-model:release-v4.3.2from Nov 30, 2021
weiwangncar:pct_pft
Merged
Correct output variable name for CLM packaging#1589davegill merged 1 commit intowrf-model:release-v4.3.2from weiwangncar:pct_pft
davegill merged 1 commit intowrf-model:release-v4.3.2from
weiwangncar:pct_pft
Conversation
Collaborator
Author
|
davegill
approved these changes
Nov 29, 2021
Contributor
|
@weiwangncar |
Collaborator
Author
|
@davegill It's fitting that you also found the fix. |
smileMchen
approved these changes
Nov 30, 2021
Contributor
|
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: CLM, PCT_PFT SOURCE: internal DESCRIPTION OF CHANGES: Problem: CLM specific variable PCT_PFT appears in standard wrfout file, even if CLM option is not selected. Solution: The packaged variable name should be pct_pft_input, rather than pct_pft. LIST OF MODIFIED FILES: Registry/Registry.EM_COMMON TESTS CONDUCTED: 1. The change removes PCT_PFT from wrfout file when CLM option is not selected. 2. The Jenkins tests are all passing. RELEASE NOTE: Starting with release-v4.3, the CLM specific variable PCT_PFT appeared in standard wrfout file, even when the CLM option was not selected. A small modification to the standard Registry file removed this incorrectly output 3d array. Other than removing this innocuous zero-valued 3d array from the output stream, there is no other impact for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: CLM, PCT_PFT
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
CLM specific variable PCT_PFT appears in standard wrfout file, even if CLM option is not selected.
Solution:
The packaged variable name should be pct_pft_input, rather than pct_pft.
LIST OF MODIFIED FILES:
Registry/Registry.EM_COMMON
TESTS CONDUCTED:
RELEASE NOTE: Starting with release-v4.3, the CLM specific variable PCT_PFT appeared in standard wrfout file, even when the CLM option was not selected. A small modification to the standard Registry file removed this incorrectly output 3d array. Other than removing this innocuous zero-valued 3d array from the output stream, there is no other impact for users.