Skip to content

Correct output variable name for CLM packaging#1589

Merged
davegill merged 1 commit intowrf-model:release-v4.3.2from
weiwangncar:pct_pft
Nov 30, 2021
Merged

Correct output variable name for CLM packaging#1589
davegill merged 1 commit intowrf-model:release-v4.3.2from
weiwangncar:pct_pft

Conversation

@weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Nov 29, 2021

TYPE: bug fix

KEYWORDS: CLM, PCT_PFT

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
CLM specific variable PCT_PFT appears in standard wrfout file, even if CLM option is not selected.

Solution:
The packaged variable name should be pct_pft_input, rather than pct_pft.

LIST OF MODIFIED FILES:
Registry/Registry.EM_COMMON

TESTS CONDUCTED:

  1. The change removes PCT_PFT from wrfout file when CLM option is not selected.
  2. The Jenkins tests are all passing.

RELEASE NOTE: Starting with release-v4.3, the CLM specific variable PCT_PFT appeared in standard wrfout file, even when the CLM option was not selected. A small modification to the standard Registry file removed this incorrectly output 3d array. Other than removing this innocuous zero-valued 3d array from the output stream, there is no other impact for users.

@weiwangncar weiwangncar requested a review from a team as a code owner November 29, 2021 22:28
@weiwangncar
Copy link
Collaborator Author

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 19           17
Number of Builds       : 48           45
Number of Simulations  : 160           155        0
Number of Comparisons  : 101           100        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@davegill
Copy link
Contributor

@weiwangncar
Wei,
Just in case we need to assign blame ...

d24be2839 Registry/Registry.EM_COMMON (Dave Gill               2021-03-04 07:14:50 -0700  788) state   real   pct_pft_input i{npft}j    misc          1     Z     i012rh   "PCT_PFT"   "PFT PERCENTAGE BY CATEGORY"  ""

@weiwangncar
Copy link
Collaborator Author

@davegill It's fitting that you also found the fix.

@davegill
Copy link
Contributor

@weiwangncar

It's fitting that you also found the fix.

:shipit:

@davegill davegill merged commit 30dbdc8 into wrf-model:release-v4.3.2 Nov 30, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: bug fix

KEYWORDS: CLM, PCT_PFT

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
CLM specific variable PCT_PFT appears in standard wrfout file, even if CLM option is not selected.

Solution:
The packaged variable name should be pct_pft_input, rather than pct_pft.

LIST OF MODIFIED FILES: 
Registry/Registry.EM_COMMON

TESTS CONDUCTED: 
1. The change removes PCT_PFT from wrfout file when CLM option is not selected.
2. The Jenkins tests are all passing.

RELEASE NOTE: Starting with release-v4.3, the CLM specific variable PCT_PFT appeared in standard wrfout file, even when the CLM option was not selected. A small modification to the standard Registry file removed this incorrectly output 3d array. Other than removing this innocuous zero-valued 3d array from the output stream, there is no other impact for users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants