Begin NMM removal from source code#1584
Merged
davegill merged 36 commits intowrf-model:developfrom Nov 29, 2021
Merged
Conversation
TYPE: feature removed KEYWORDS: NMM SOURCE: internal DESCRIPTION OF CHANGES: If we consider the act of adding in new features to the WRF repository as a "constructionist" activity, then this PR begins the largest deconstructionist activity ever undertake in WRF. The Philosophy of Deconstructivism places an emphasis on appearance. LIST OF MODIFIED FILES: Deleted: Registry/Registry.NMM dyn_nmm/BALANCE_COMS.F dyn_nmm/BALANCE_PARS.F dyn_nmm/BUCKETS.F dyn_nmm/CLTEND.F dyn_nmm/DSTRB.F dyn_nmm/Makefile dyn_nmm/NMM_NEST_UTILS1.F dyn_nmm/RDTEMP.F dyn_nmm/adve_optim.h dyn_nmm/adve_orig.h dyn_nmm/depend.dyn_nmm dyn_nmm/init_modules_nmm.F dyn_nmm/module_ADVECTION.F dyn_nmm/module_BC_NMM.F dyn_nmm/module_BNDRY_COND.F dyn_nmm/module_CLDWTR.F dyn_nmm/module_CTLBLK.F dyn_nmm/module_DIFFUSION_NMM.F dyn_nmm/module_GWD.F dyn_nmm/module_HIFREQ.F dyn_nmm/module_IGWAVE_ADJUST.F dyn_nmm/module_INDX.F dyn_nmm/module_MPP.F dyn_nmm/module_MPPINIT.F dyn_nmm/module_NEST_UTIL.F dyn_nmm/module_NONHY_DYNAM.F dyn_nmm/module_PHYSICS_CALLS.F dyn_nmm/module_PRECIP_ADJUST.F dyn_nmm/module_SMOOTH_TERRAIN.F dyn_nmm/module_STATS_FOR_MOVE.F dyn_nmm/module_TERRAIN.F dyn_nmm/module_TIMERS.F dyn_nmm/module_ZEROX.F dyn_nmm/module_initialize_real.F dyn_nmm/module_initialize_tropical_cyclone.F dyn_nmm/module_membrane_mslp.F dyn_nmm/module_relax.F dyn_nmm/module_si_io_nmm.F dyn_nmm/module_swath.F dyn_nmm/module_tornado_genesis.F dyn_nmm/module_tracker.F dyn_nmm/nmm_get_cpu.c dyn_nmm/nmm_loop_basemacros.h dyn_nmm/nmm_loop_macros.h dyn_nmm/shift_domain_nmm.F dyn_nmm/solve_nmm.F dyn_nmm/start_domain_nmm.F test/nmm_real/namelist.input test/nmm_real/namelist.input.HWRF test/nmm_real/tomorrow test/nmm_tropical_cyclone/README.NMM.TROPICAL_CYCLONE test/nmm_tropical_cyclone/input.d test/nmm_tropical_cyclone/land.nml test/nmm_tropical_cyclone/namelist.input test/nmm_tropical_cyclone/namelist.wps test/nmm_tropical_cyclone/sigma.d test/nmm_tropical_cyclone/sound.d test/nmm_tropical_cyclone/sound_gfdl.d test/nmm_tropical_cyclone/sound_jordan.d test/nmm_tropical_cyclone/sound_wet.d test/nmm_tropical_cyclone/storm.center Modified: clean TESTS CONDUCTED: 1. No "problems" per se. Just removing deadwood code. 2. Jeez, I hope that I can say All Jenkins tests are a PASS. RELEASE NOTE: Starting with release-v4.4, the NMM dynamical core and options are being removed from the WRF repository.
modified: external/RSL_LITE/gen_comms.c modified: external/RSL_LITE/module_dm.F modified: external/RSL_LITE/tfp_tester.F
modified: Makefile
modified: frame/Makefile modified: main/Makefile
modified: phys/Makefile
modified: frame/module_bdywrite.F modified: frame/module_domain.F modified: frame/module_integrate.F modified: frame/module_nesting.F
modified: main/depend.common
modified: share/interp_fcn.F
Contributor
Author
|
@mgduda |
modified: CODEOWNERS
Contributor
Author
|
@kkeene44 |
UNfortunately, there are a ba-freaking-zillion NMM_CORE tests in the WRF source code. Until they are all excised, we can't remove all of the env var settings in the these scripts. modified: compile modified: configure
modified: share/dfi.F
modified: share/init_modules.F
modified: share/input_wrf.F modified: share/output_wrf.F
modified: share/input_wrf.F modified: share/mediation_feedback_domain.F modified: share/mediation_force_domain.F modified: share/mediation_integrate.F modified: share/mediation_interp_domain.F modified: share/mediation_nest_move.F
modified: share/module_check_a_mundo.F modified: share/module_interp_store.F modified: share/module_model_constants.F modified: share/module_optional_input.F modified: share/module_soil_pre.F
modified: share/module_soil_pre.F modified: share/module_trajectory.F modified: share/start_domain.F modified: share/wrf_ext_write_field.F modified: share/wrf_timeseries.F
modified: share/solve_interface.F
The dimensions are wrong with a second test using the NMM assumption about dims being ide-1 and jde-1. modified: input_wrf.F
modified: external/RSL_LITE/module_dm.F
Associated with that is now an unused file: frame/module_io_quilt_new.F modified: frame/Makefile modified: frame/module_dm_stubs.F modified: frame/module_io_quilt.F deleted: frame/module_io_quilt_new.F modified: frame/module_wrf_error.F
modified: module_cumulus_driver.F
Mods to Makefile and depend file, and MP driver modified: main/depend.common modified: phys/Makefile modified: phys/module_microphysics_driver.F deleted: phys/module_mp_HWRF.F deleted: phys/module_ra_HWRF.F
Contributor
Author
Folks, |
Collaborator
|
Sounds good. Thanks,
…On Mon, Nov 22, 2021 at 8:37 PM Dave Gill ***@***.***> wrote:
@weiwangncar <https://github.com/weiwangncar> @dudhia
<https://github.com/dudhia>
Would it be possible to check ARW results before and after this
'deconstruction'?
Folks,
I have modified the regression system to allow before vs after checking.
For each of the tests that are conducted, the mods to this NO_NMM branch
give bit-wise identical to the develop branch from which this NO_NMM branch
was cut.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1584 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77CH6T7SERHTU6T75OTUNMEA7ANCNFSM5IIFDIMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
modified: phys/module_cumulus_driver.F modified: phys/module_diagnostics_driver.F modified: phys/module_fddagd_driver.F modified: phys/module_microphysics_driver.F modified: phys/module_pbl_driver.F modified: phys/module_radiation_driver.F modified: phys/module_surface_driver.F
Contributor
Author
|
@liujake |
modified: var/build/depend.txt
Contributor
Author
|
@weiwangncar @dudhia |
Contributor
Author
|
@liujake and These both pass: and all 43 executables |
Contributor
Author
|
@weiwangncar @dudhia |
Contributor
Author
|
@weiwangncar @dudhia |
Contributor
Author
|
@kkeene44 |
Contributor
Author
|
@mgduda |
liujake
approved these changes
Nov 26, 2021
Contributor
liujake
left a comment
liujake
left a comment
There was a problem hiding this comment.
WRFDA regression test passed with this branch.
Collaborator
That sounds easy enough. |
Collaborator
|
@davegill I've repeated my single case test with the latest code, and they produce identical results. |
weiwangncar
approved these changes
Nov 29, 2021
Collaborator
|
@davegill |
hsbadr
added a commit
to hsbadr/WRF
that referenced
this pull request
Dec 12, 2021
This reverts commit a646bb1.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: feature removed KEYWORDS: NMM SOURCE: internal DESCRIPTION OF CHANGES: If we consider the act of adding in new features to the WRF repository as a "constructionist" activity, then this PR begins the largest deconstructionist effort ever undertake in WRF. The Philosophy of Deconstructivism places an emphasis on appearance. Perhaps the bard has a quote appropos to someone working on a commit for a PR, where that PR is at once a massive change and yet is intended to have exactly zero impact: _It is a tale. Told by an idiot, full of sound and fury, Signifying nothing._ LIST OF MODIFIED FILES: _Deleted:_ D Registry/Registry.NMM D dyn_nmm/BALANCE_COMS.F D dyn_nmm/BALANCE_PARS.F D dyn_nmm/BUCKETS.F D dyn_nmm/CLTEND.F D dyn_nmm/DSTRB.F D dyn_nmm/Makefile D dyn_nmm/NMM_NEST_UTILS1.F D dyn_nmm/RDTEMP.F D dyn_nmm/adve_optim.h D dyn_nmm/adve_orig.h D dyn_nmm/depend.dyn_nmm D dyn_nmm/init_modules_nmm.F D dyn_nmm/module_ADVECTION.F D dyn_nmm/module_BC_NMM.F D dyn_nmm/module_BNDRY_COND.F D dyn_nmm/module_CLDWTR.F D dyn_nmm/module_CTLBLK.F D dyn_nmm/module_DIFFUSION_NMM.F D dyn_nmm/module_GWD.F D dyn_nmm/module_HIFREQ.F D dyn_nmm/module_IGWAVE_ADJUST.F D dyn_nmm/module_INDX.F D dyn_nmm/module_MPP.F D dyn_nmm/module_MPPINIT.F D dyn_nmm/module_NEST_UTIL.F D dyn_nmm/module_NONHY_DYNAM.F D dyn_nmm/module_PHYSICS_CALLS.F D dyn_nmm/module_PRECIP_ADJUST.F D dyn_nmm/module_SMOOTH_TERRAIN.F D dyn_nmm/module_STATS_FOR_MOVE.F D dyn_nmm/module_TERRAIN.F D dyn_nmm/module_TIMERS.F D dyn_nmm/module_ZEROX.F D dyn_nmm/module_initialize_real.F D dyn_nmm/module_initialize_tropical_cyclone.F D dyn_nmm/module_membrane_mslp.F D dyn_nmm/module_relax.F D dyn_nmm/module_si_io_nmm.F D dyn_nmm/module_swath.F D dyn_nmm/module_tornado_genesis.F D dyn_nmm/module_tracker.F D dyn_nmm/nmm_get_cpu.c D dyn_nmm/nmm_loop_basemacros.h D dyn_nmm/nmm_loop_macros.h D dyn_nmm/shift_domain_nmm.F D dyn_nmm/solve_nmm.F D dyn_nmm/start_domain_nmm.F D frame/module_io_quilt_new.F D phys/module_mp_HWRF.F D phys/module_ra_HWRF.F D test/nmm_real/namelist.input D test/nmm_real/namelist.input.HWRF D test/nmm_real/tomorrow D test/nmm_tropical_cyclone/README.NMM.TROPICAL_CYCLONE D test/nmm_tropical_cyclone/input.d D test/nmm_tropical_cyclone/land.nml D test/nmm_tropical_cyclone/namelist.input D test/nmm_tropical_cyclone/namelist.wps D test/nmm_tropical_cyclone/sigma.d D test/nmm_tropical_cyclone/sound.d D test/nmm_tropical_cyclone/sound_gfdl.d D test/nmm_tropical_cyclone/sound_jordan.d D test/nmm_tropical_cyclone/sound_wet.d D test/nmm_tropical_cyclone/storm.center _Modified:_ M .github/CODEOWNERS M Makefile M clean M compile M configure M external/RSL_LITE/gen_comms.c M external/RSL_LITE/module_dm.F M external/RSL_LITE/tfp_tester.F M frame/Makefile M frame/module_bdywrite.F M frame/module_dm_stubs.F M frame/module_domain.F M frame/module_integrate.F M frame/module_io_quilt.F M frame/module_nesting.F M frame/module_wrf_error.F M main/Makefile M main/depend.common M phys/Makefile M phys/module_cumulus_driver.F M phys/module_diagnostics_driver.F M phys/module_fddagd_driver.F M phys/module_microphysics_driver.F M phys/module_pbl_driver.F M phys/module_radiation_driver.F M phys/module_surface_driver.F M share/dfi.F M share/init_modules.F M share/input_wrf.F M share/interp_fcn.F M share/mediation_feedback_domain.F M share/mediation_force_domain.F M share/mediation_integrate.F M share/mediation_interp_domain.F M share/mediation_nest_move.F M share/mediation_wrfmain.F M share/module_check_a_mundo.F M share/module_interp_store.F M share/module_model_constants.F M share/module_optional_input.F M share/module_soil_pre.F M share/module_trajectory.F M share/output_wrf.F M share/set_timekeeping.F M share/solve_interface.F M share/start_domain.F M share/wrf_ext_write_field.F M share/wrf_timeseries.F M var/build/depend.txt TESTS CONDUCTED: 1. No "problems" per se. Just removing deadwood code. 2. All Jenkins tests are a PASS. 3. DA code still builds. 4. Restart tests OK. 5. Results for each regression test are identical before vs after. 6. Results for larger tests cases are also bit-for-bit (Wei Wang). 7. Code passes DA regression tests (Jake Liu). RELEASE NOTE: Starting with release-v4.4, the NMM dynamical core and some NMM-specific source code are being removed from the WRF repository. WRF release-v4.3.x is the latest release with the NMM build options still available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: feature removed
KEYWORDS: NMM
SOURCE: internal
DESCRIPTION OF CHANGES:
If we consider the act of adding in new features to the WRF repository as a "constructionist" activity, then this
PR begins the largest deconstructionist effort ever undertake in WRF.
The Philosophy of Deconstructivism places an emphasis on appearance.
Perhaps the bard has a quote appropos to someone working on a commit for a PR, where that PR is at once a massive
change and yet is intended to have exactly zero impact:
It is a tale. Told by an idiot, full of sound and fury, Signifying nothing.
LIST OF MODIFIED FILES:
Deleted:
D Registry/Registry.NMM
D dyn_nmm/BALANCE_COMS.F
D dyn_nmm/BALANCE_PARS.F
D dyn_nmm/BUCKETS.F
D dyn_nmm/CLTEND.F
D dyn_nmm/DSTRB.F
D dyn_nmm/Makefile
D dyn_nmm/NMM_NEST_UTILS1.F
D dyn_nmm/RDTEMP.F
D dyn_nmm/adve_optim.h
D dyn_nmm/adve_orig.h
D dyn_nmm/depend.dyn_nmm
D dyn_nmm/init_modules_nmm.F
D dyn_nmm/module_ADVECTION.F
D dyn_nmm/module_BC_NMM.F
D dyn_nmm/module_BNDRY_COND.F
D dyn_nmm/module_CLDWTR.F
D dyn_nmm/module_CTLBLK.F
D dyn_nmm/module_DIFFUSION_NMM.F
D dyn_nmm/module_GWD.F
D dyn_nmm/module_HIFREQ.F
D dyn_nmm/module_IGWAVE_ADJUST.F
D dyn_nmm/module_INDX.F
D dyn_nmm/module_MPP.F
D dyn_nmm/module_MPPINIT.F
D dyn_nmm/module_NEST_UTIL.F
D dyn_nmm/module_NONHY_DYNAM.F
D dyn_nmm/module_PHYSICS_CALLS.F
D dyn_nmm/module_PRECIP_ADJUST.F
D dyn_nmm/module_SMOOTH_TERRAIN.F
D dyn_nmm/module_STATS_FOR_MOVE.F
D dyn_nmm/module_TERRAIN.F
D dyn_nmm/module_TIMERS.F
D dyn_nmm/module_ZEROX.F
D dyn_nmm/module_initialize_real.F
D dyn_nmm/module_initialize_tropical_cyclone.F
D dyn_nmm/module_membrane_mslp.F
D dyn_nmm/module_relax.F
D dyn_nmm/module_si_io_nmm.F
D dyn_nmm/module_swath.F
D dyn_nmm/module_tornado_genesis.F
D dyn_nmm/module_tracker.F
D dyn_nmm/nmm_get_cpu.c
D dyn_nmm/nmm_loop_basemacros.h
D dyn_nmm/nmm_loop_macros.h
D dyn_nmm/shift_domain_nmm.F
D dyn_nmm/solve_nmm.F
D dyn_nmm/start_domain_nmm.F
D frame/module_io_quilt_new.F
D phys/module_mp_HWRF.F
D phys/module_ra_HWRF.F
D test/nmm_real/namelist.input
D test/nmm_real/namelist.input.HWRF
D test/nmm_real/tomorrow
D test/nmm_tropical_cyclone/README.NMM.TROPICAL_CYCLONE
D test/nmm_tropical_cyclone/input.d
D test/nmm_tropical_cyclone/land.nml
D test/nmm_tropical_cyclone/namelist.input
D test/nmm_tropical_cyclone/namelist.wps
D test/nmm_tropical_cyclone/sigma.d
D test/nmm_tropical_cyclone/sound.d
D test/nmm_tropical_cyclone/sound_gfdl.d
D test/nmm_tropical_cyclone/sound_jordan.d
D test/nmm_tropical_cyclone/sound_wet.d
D test/nmm_tropical_cyclone/storm.center
Modified:
M .github/CODEOWNERS
M Makefile
M clean
M compile
M configure
M external/RSL_LITE/gen_comms.c
M external/RSL_LITE/module_dm.F
M external/RSL_LITE/tfp_tester.F
M frame/Makefile
M frame/module_bdywrite.F
M frame/module_dm_stubs.F
M frame/module_domain.F
M frame/module_integrate.F
M frame/module_io_quilt.F
M frame/module_nesting.F
M frame/module_wrf_error.F
M main/Makefile
M main/depend.common
M phys/Makefile
M phys/module_cumulus_driver.F
M phys/module_diagnostics_driver.F
M phys/module_fddagd_driver.F
M phys/module_microphysics_driver.F
M phys/module_pbl_driver.F
M phys/module_radiation_driver.F
M phys/module_surface_driver.F
M share/dfi.F
M share/init_modules.F
M share/input_wrf.F
M share/interp_fcn.F
M share/mediation_feedback_domain.F
M share/mediation_force_domain.F
M share/mediation_integrate.F
M share/mediation_interp_domain.F
M share/mediation_nest_move.F
M share/mediation_wrfmain.F
M share/module_check_a_mundo.F
M share/module_interp_store.F
M share/module_model_constants.F
M share/module_optional_input.F
M share/module_soil_pre.F
M share/module_trajectory.F
M share/output_wrf.F
M share/set_timekeeping.F
M share/solve_interface.F
M share/start_domain.F
M share/wrf_ext_write_field.F
M share/wrf_timeseries.F
M var/build/depend.txt
TESTS CONDUCTED:
RELEASE NOTE: Starting with release-v4.4, the NMM dynamical core and some NMM-specific source code are being removed from the WRF repository. WRF release-v4.3.x is the latest release with the NMM build options still available.