Restrict which CG PBLs may use FG LES PBL#1578
Closed
davegill wants to merge 3 commits intowrf-model:release-v4.3.2from
Closed
Restrict which CG PBLs may use FG LES PBL#1578davegill wants to merge 3 commits intowrf-model:release-v4.3.2from
davegill wants to merge 3 commits intowrf-model:release-v4.3.2from
Conversation
TYPE: bug fix KEYWORDS: PBL, MYNN, LES SOURCE: internal DESCRIPTION OF CHANGES: Problem: The MYNN PBL schemes are not to be used on a coarse grid when the LES scheme is used on a finer grid. Solution: A controlled stop is put in place when these namelist options are selected. LIST OF MODIFIED FILES: modified: Registry/Registry.EM_COMMON modified: share/module_check_a_mundo.F TESTS CONDUCTED: 1. When the MYNN and LES are selected, the code successfully stops. 2. Jenkins is all PASS. RELEASE NOTE: A test was introduced to stop the combination of either of the MYNN PBL schemes on coarser grids with the LES PBL option selected on a finer grid.
Contributor
Author
|
Jenkins is OK |
kkeene44
previously approved these changes
Nov 9, 2021
Collaborator
|
This is a placeholder stop until a better fix is found. Issue #1514 has some workarounds and can be mentioned in the release note. The stop message could also recommend YSU PBL as a safe option with no packaged arrays. I am not sure if MYJ is safe as it has packaged arrays. |
Collaborator
|
adding el_pbl and tke_pbl to the les package would allow MYJ and shinhong to work with LES in nests (Shin-Hong has these as diagnostics). |
Categorize all other CG PBL options as nonacceptable when a FG LES PBL is requested modified: Registry/Registry.EM_COMMON modified: share/module_check_a_mundo.F
Contributor
Author
|
Choosing #1596 "PBL + LES restrictions" as a temporary solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: PBL, LES
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Only the YSU PBL scheme has no packaged variables. If a user wants to have any other PBL scheme on the CG,
and an LES PBL on the FG, the model will have memory corruption problems. This error is hard to detect.
Solution:
scheme does not need them, this does not add any memory, and this permits both the MYJ and
ShinHong PBL schemes to be used.
ISSUES:
Partially addresses #1514
LIST OF MODIFIED FILES:
modified: Registry/Registry.EM_COMMON
modified: share/module_check_a_mundo.F
TESTS CONDUCTED:
RELEASE NOTE: A test was introduced to stop the incorrect combination of particular PBL schemes on coarser grids with the LES PBL option selected on a finer grid. Previously, this problem caused an inconsistent number of variables on the CG and FG, which caused segmentation faults when trying to do feedback or advection of unavailable fields.