Skip to content

Syntax errors in physics routines: *- and *+ #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davegill merged 1 commit into from
Nov 29, 2021
Merged

Syntax errors in physics routines: *- and *+ #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phys/module_mp_nssl_2mom.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ SUBROUTINE nssl_2mom_init( &
write(0,*) 'READ_NAMELIST: PROBLEM WITH NSSL_MP_PARAMS namelist: not found or bad token'
ENDIF
IF ( wrf_dm_on_monitor() .and. .not. wrote_namelist ) THEN
open(15,file='namelist.output',status='old',action='readwrite', access='append',form='formatted')
open(15,file='namelist.output',status='old',action='readwrite', position='append',form='formatted')
write(15,NML=nssl_mp_params)
close(15)
wrote_namelist = .true.
Expand Down
2 changes: 1 addition & 1 deletion phys/module_mp_ntu.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6203,7 +6203,7 @@ SUBROUTINE LARGE_DT(DT,TK1D,QV1D,P1D,RHO,QC1D,QR1D,QI1D,QS1D, &
ENDIF
QCLsh = QCLS1*ESH*VTQSH*NH1D*(SASR2*GSM3+SASR1*2.*GH2*GSM2+&
GH3*GSM1)
NCLsh = NCLS1*ESH*VTNSH*NH1D*(SASR2*GS3*+SASR1*2.*GH2*GS2+ &
NCLsh = NCLS1*ESH*VTNSH*NH1D*(SASR2*GS3 +SASR1*2.*GH2*GS2+ &
Copy link
Contributor Author

@davegill davegill Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiwangncar @dudhia
This one is the biggy

Copy link
Collaborator

@weiwangncar weiwangncar Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davegill This looks good to me. I'll ask the author to approve it too.

Copy link
Contributor Author

@davegill davegill Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wei.
Could we also ask the author to comment on the likely impact of multiplying, instead of adding those terms? That might be significant.

Copy link
Collaborator

@weiwangncar weiwangncar Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davegill I sent him this page, and hopefully he will see your comment.

GH3)
QCLsh = MIN(QCLsh,QS1D*iDT)
NCLsh = MIN(NCLsh,NS1D*iDT)
Expand Down
4 changes: 2 additions & 2 deletions phys/module_sf_noahmplsm.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7919,8 +7919,8 @@ SUBROUTINE TRIGGER_IRRIGATION(parameters,NSOIL,ZSOIL,SH2O,FVEG,
SMCAVL = 0.0
SMCLIM = 0.0
! estimate available water and field capacity for the root zone
SMCAVL = (SH2O(1)-parameters%SMCWLT(1))*-1*ZSOIL(1) ! current soil water (m)
SMCLIM = (parameters%SMCREF(1)-parameters%SMCWLT(1))*-1*ZSOIL(1) ! available water (m)
SMCAVL = (SH2O(1)-parameters%SMCWLT(1))*(-1)*ZSOIL(1) ! current soil water (m)
SMCLIM = (parameters%SMCREF(1)-parameters%SMCWLT(1))*(-1)*ZSOIL(1) ! available water (m)
DO K = 2, parameters%NROOT
SMCAVL = SMCAVL + (SH2O(K)-parameters%SMCWLT(K))*(ZSOIL(K-1) - ZSOIL(K))
SMCLIM = SMCLIM + (parameters%SMCREF(K)-parameters%SMCWLT(K))*(ZSOIL(K-1) - ZSOIL(K))
Expand Down