configure script missing quotes in two echo statements#1576
Merged
davegill merged 1 commit intowrf-model:release-v4.3.2from Nov 29, 2021
Merged
configure script missing quotes in two echo statements#1576davegill merged 1 commit intowrf-model:release-v4.3.2from
davegill merged 1 commit intowrf-model:release-v4.3.2from
Conversation
TYPE: bug fix SOURCE: internal DESCRIPTION OF CHANGES: Problem: When building with NetCDF that does not support compression, the warning statements that are printed out are misaligned, due to missing trailing quotes. Solution: Add those quotes back in. LIST OF MODIFIED FILES: modified: configure TESTS CONDUCTED: 1. The printout is now aesthetically appealing. 2. Hopefully, Jenkins is all PASS.
Contributor
Author
|
Jenkins is OK |
kkeene44
approved these changes
Nov 9, 2021
Contributor
Author
|
@smileMchen |
smileMchen
approved these changes
Nov 29, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix
KEYWORDS: configure, shell, echo
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
When building with NetCDF that does not support compression, the warning statements that
are printed out are misaligned, due to missing trailing quotes at the end of some `echo` statements in the
`configure` script.
Solution:
Add those quotes back in.
LIST OF MODIFIED FILES:
modified: configure
TESTS CONDUCTED:
1. The printout is now aesthetically appealing. Initially we had a mortifying display of the word `echo`, and the
accompanying alignment disarray that would be associated with banal shell scripting encroaching upon a user's otherwise elevated build experience:
```
Please make sure NETCDF version is 4.1.3 or later and was built with
--enable-netcdf4
OR set NETCDF_classic variable
bash/ksh : export NETCDF_classic=1
echo csh : setenv NETCDF_classic 1
```
After much soul searching, an appropriate solution was uncovered, resulting in reduced messaging dissonance:
```
Please make sure NETCDF version is 4.1.3 or later and was built with
--enable-netcdf4
OR set NETCDF_classic variable
bash/ksh : export NETCDF_classic=1
csh : setenv NETCDF_classic 1
```
2. Jenkins is all PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: configure, shell, echo
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
When building with NetCDF that does not support compression, the warning statements that
are printed out are misaligned, due to missing trailing quotes at the end of some
echostatements in theconfigurescript.Solution:
Add those quotes back in.
LIST OF MODIFIED FILES:
modified: configure
TESTS CONDUCTED:
echo, and theaccompanying alignment disarray that would be associated with banal shell scripting encroaching upon a user's otherwise elevated build experience:
After much soul searching, an appropriate solution was uncovered, resulting in reduced messaging dissonance: