Skip to content

configure script missing quotes in two echo statements#1576

Merged
davegill merged 1 commit intowrf-model:release-v4.3.2from
davegill:echo2
Nov 29, 2021
Merged

configure script missing quotes in two echo statements#1576
davegill merged 1 commit intowrf-model:release-v4.3.2from
davegill:echo2

Conversation

@davegill
Copy link
Contributor

@davegill davegill commented Nov 5, 2021

TYPE: bug fix

KEYWORDS: configure, shell, echo

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
When building with NetCDF that does not support compression, the warning statements that
are printed out are misaligned, due to missing trailing quotes at the end of some echo statements in the
configure script.

Solution:
Add those quotes back in.

LIST OF MODIFIED FILES:
modified: configure

TESTS CONDUCTED:

  1. The printout is now aesthetically appealing. Initially we had a mortifying display of the word echo, and the
    accompanying alignment disarray that would be associated with banal shell scripting encroaching upon a user's otherwise elevated build experience:
Please make sure NETCDF version is 4.1.3 or later and was built with         
--enable-netcdf4                                                             

OR set NETCDF_classic variable                                               
   bash/ksh : export NETCDF_classic=1
      echo  csh : setenv NETCDF_classic 1

After much soul searching, an appropriate solution was uncovered, resulting in reduced messaging dissonance:

Please make sure NETCDF version is 4.1.3 or later and was built with         
--enable-netcdf4                                                             

OR set NETCDF_classic variable                                               
   bash/ksh : export NETCDF_classic=1                                        
        csh : setenv NETCDF_classic 1     
  1. Jenkins is all PASS.

TYPE: bug fix

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
When building with NetCDF that does not support compression, the warning statements that
are printed out are misaligned, due to missing trailing quotes.

Solution:
Add those quotes back in.

LIST OF MODIFIED FILES:
modified:   configure

TESTS CONDUCTED:
1. The printout is now aesthetically appealing.
2. Hopefully, Jenkins is all PASS.
@davegill
Copy link
Contributor Author

davegill commented Nov 5, 2021

Jenkins is OK

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 64b7a931c94481211c4a5919534951cd6036d254, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1576. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           17
    Number of Builds       : 48           45
    Number of Simulations  : 160           155        0
    Number of Comparisons  : 101           100        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

@davegill davegill changed the title configure script missing quotes in two echo statments configure script missing quotes in two echo statements Nov 5, 2021
@davegill
Copy link
Contributor Author

@smileMchen
Ming,
This should also be a simple one to review. I forgot to put in the trailing quote characters. Only the output from two echo statements was incorrect.

@davegill davegill merged commit 4ff1e3d into wrf-model:release-v4.3.2 Nov 29, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: bug fix

KEYWORDS: configure, shell, echo

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
When building with NetCDF that does not support compression, the warning statements that
are printed out are misaligned, due to missing trailing quotes at the end of some `echo` statements in the
`configure` script.

Solution:
Add those quotes back in.

LIST OF MODIFIED FILES:
modified:   configure

TESTS CONDUCTED: 
1. The printout is now aesthetically appealing. Initially we had a mortifying display of the word `echo`, and the 
accompanying alignment disarray that would be associated with banal shell scripting encroaching upon a user's otherwise elevated build experience:
```
Please make sure NETCDF version is 4.1.3 or later and was built with         
--enable-netcdf4                                                             

OR set NETCDF_classic variable                                               
   bash/ksh : export NETCDF_classic=1
      echo  csh : setenv NETCDF_classic 1
```
After much soul searching, an appropriate solution was uncovered, resulting in reduced messaging dissonance:
```
Please make sure NETCDF version is 4.1.3 or later and was built with         
--enable-netcdf4                                                             

OR set NETCDF_classic variable                                               
   bash/ksh : export NETCDF_classic=1                                        
        csh : setenv NETCDF_classic 1     
```
2. Jenkins is all PASS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants