Bug fix: Adding eclipse module to radiation driver's dependency list#1544
Merged
weiwangncar merged 1 commit intowrf-model:release-v4.3.1from Sep 15, 2021
weiwangncar:eclipse-fix
Merged
Bug fix: Adding eclipse module to radiation driver's dependency list#1544weiwangncar merged 1 commit intowrf-model:release-v4.3.1from weiwangncar:eclipse-fix
weiwangncar merged 1 commit intowrf-model:release-v4.3.1from
weiwangncar:eclipse-fix
Conversation
davegill
approved these changes
Sep 14, 2021
Collaborator
Author
dudhia
approved these changes
Sep 15, 2021
Collaborator
|
OK, done
…On Wed, Sep 15, 2021 at 2:01 PM weiwangncar ***@***.***> wrote:
@kkeene44 <https://github.com/kkeene44> @dudhia
<https://github.com/dudhia> Can one of you approve this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1544 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77GT5ZGMSV7NTDVSUQDUCD3RTANCNFSM5CPIWIVQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: eclipse module, radiation driver dependency SOURCE: internal DESCRIPTION OF CHANGES: Problem: The newly added module_ra_eclipse.F was not added to the dependency list of radiation driver. This sometimes causes compilation failures. Solution: Add module_ra_eclipse to radiation dependency list. LIST OF MODIFIED FILES: M main/depend.common TESTS CONDUCTED: - It is hard to test that there are no more intermittent build failures caused by this missing dependency. :) - Jenkins tests are passing. RELEASE NOTE: Adding module_ra_eclipse.o to radiation driver's dependency list to avoid occasional compilation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: eclipse module, radiation driver dependency
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The newly added module_ra_eclipse.F was not added to the dependency list of radiation driver. This sometimes causes
compilation failures.
Solution:
Add module_ra_eclipse to radiation dependency list.
LIST OF MODIFIED FILES:
M main/depend.common
TESTS CONDUCTED:
RELEASE NOTE: Adding module_ra_eclipse.o to radiation driver's dependency list to avoid occasional compilation failures.