Skip to content

Correct units for several NTU microphysics variables#1532

Merged
weiwangncar merged 2 commits intowrf-model:release-v4.3.1from
weiwangncar:ntu-units
Sep 15, 2021
Merged

Correct units for several NTU microphysics variables#1532
weiwangncar merged 2 commits intowrf-model:release-v4.3.1from
weiwangncar:ntu-units

Conversation

@weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Jul 14, 2021

TYPE: text change

KEYWORDS: units in Registry

SOURCE: internal, Tzu-Chin Tsai (NTU)

DESCRIPTION OF CHANGES:
Problem:
The units for 7 new NTU microphysics variables are incorrectly specified in Registry.EM_COMMON.

Solution:
This PR corrects them.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON

TESTS CONDUCTED:

  1. Text change only. No effect on results
  2. The Jenkins tests are all passing.

RELEASE NOTE: Units specified in Registry are corrected for several NTU microphysics variables.

@weiwangncar weiwangncar requested a review from a team as a code owner July 14, 2021 17:31
@weiwangncar
Copy link
Collaborator Author

Passed Jenkins tests:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 19           18
Number of Builds       : 48           46
Number of Simulations  : 163           161        0
Number of Comparisons  : 103           102        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

dudhia
dudhia previously approved these changes Jul 14, 2021
@tzuchin12
Copy link
Contributor

Thanks for the corrections. It is fine to me now.

@weiwangncar weiwangncar merged commit a80a449 into wrf-model:release-v4.3.1 Sep 15, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: text change

KEYWORDS: units in Registry

SOURCE: internal, Tzu-Chin Tsai (NTU)

DESCRIPTION OF CHANGES:
Problem:
The units for 7 new NTU microphysics variables are incorrectly specified in Registry.EM_COMMON.

Solution:
This PR corrects them.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON

TESTS CONDUCTED:

Text change only. No effect on results
The Jenkins tests are all passing.
RELEASE NOTE: Units specified in Registry are corrected for several NTU microphysics variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants