Correct units for several NTU microphysics variables#1532
Merged
weiwangncar merged 2 commits intowrf-model:release-v4.3.1from Sep 15, 2021
weiwangncar:ntu-units
Merged
Correct units for several NTU microphysics variables#1532weiwangncar merged 2 commits intowrf-model:release-v4.3.1from weiwangncar:ntu-units
weiwangncar merged 2 commits intowrf-model:release-v4.3.1from
weiwangncar:ntu-units
Conversation
Collaborator
Author
|
Passed Jenkins tests: |
dudhia
previously approved these changes
Jul 14, 2021
Contributor
|
Thanks for the corrections. It is fine to me now. |
davegill
approved these changes
Sep 15, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: text change KEYWORDS: units in Registry SOURCE: internal, Tzu-Chin Tsai (NTU) DESCRIPTION OF CHANGES: Problem: The units for 7 new NTU microphysics variables are incorrectly specified in Registry.EM_COMMON. Solution: This PR corrects them. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON TESTS CONDUCTED: Text change only. No effect on results The Jenkins tests are all passing. RELEASE NOTE: Units specified in Registry are corrected for several NTU microphysics variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: text change
KEYWORDS: units in Registry
SOURCE: internal, Tzu-Chin Tsai (NTU)
DESCRIPTION OF CHANGES:
Problem:
The units for 7 new NTU microphysics variables are incorrectly specified in Registry.EM_COMMON.
Solution:
This PR corrects them.
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
TESTS CONDUCTED:
RELEASE NOTE: Units specified in Registry are corrected for several NTU microphysics variables.