Skip to content

Add Namelist Option 'reasonable_time_step_ratio' to README.namelist File#1472

Merged
davegill merged 2 commits intowrf-model:release-v4.3from
kkeene44:add_reasonable_time_step_readme
Apr 19, 2021
Merged

Add Namelist Option 'reasonable_time_step_ratio' to README.namelist File#1472
davegill merged 2 commits intowrf-model:release-v4.3from
kkeene44:add_reasonable_time_step_readme

Conversation

@kkeene44
Copy link
Collaborator

@kkeene44 kkeene44 commented Apr 16, 2021

TYPE: text only

KEYWORDS: reasonable_time_step_ratio, README.namelist, namelist

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
The new namelist option "reasonable_time_step_ratio" was not added to the README.namelist file when it was
originally added to the Registry (PR #784).

Solution:
Added it to the README.namelist file.

LIST OF MODIFIED FILES:
M run/README.namelist

TESTS CONDUCTED:

  1. Text only - no tests needed
  2. Jenkins tests - ok

@kkeene44 kkeene44 requested a review from a team as a code owner April 16, 2021 20:00
@davegill
Copy link
Contributor

jenkins

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: a2e2e0def8ef45c8d49945b4119e8ce487cef2b3, requested by: kkeene44 for PR: https://github.com/wrf-model/WRF/pull/1472. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

@davegill davegill self-requested a review April 16, 2021 21:04
Copy link
Contributor

@davegill davegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@weiwangncar
Copy link
Collaborator

@davegill Why should this PR trigger a test?

@davegill
Copy link
Contributor

@weiwangncar

Why should this PR trigger a test?

We were not very general with what could be excused from causing a test. At one time "README" type files were exempt from causing a jenkins test, but not anymore. We can revisit this later. I'll bring it up at our next jenkins meeting.

@davegill davegill merged commit ee34776 into wrf-model:release-v4.3 Apr 19, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
…ile (wrf-model#1472)

TYPE: text only

KEYWORDS: reasonable_time_step_ratio, README.namelist, namelist

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
The new namelist option "reasonable_time_step_ratio" was not added to the README.namelist file when it was 
originally added to the Registry (PR wrf-model#784). 

Solution:
Added it to the README.namelist file.

LIST OF MODIFIED FILES: 
M  run/README.namelist

TESTS CONDUCTED: 
1. Text only - no tests needed
2. Jenkins tests - ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants