Remove Gecros crop option in Noah-MP#1346
Closed
cenlinhe wants to merge 3 commits intowrf-model:developfrom
Closed
Remove Gecros crop option in Noah-MP#1346cenlinhe wants to merge 3 commits intowrf-model:developfrom
cenlinhe wants to merge 3 commits intowrf-model:developfrom
Conversation
Synchronize the develop branch from official WRF GitHub
…ption (iopt_crop=2); It was not fully coupled into Noah-MP and might cause inconsistency in some relevant energy flux
Contributor
Author
|
This PR is closed because the Noah-MP team decided not to remove Gecros from Noah-MP for the upcoming WRF release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the gecros crop option (opt_crop=2) in Noah-MP
TYPE: feature removed
KEYWORDS: Noah-MP, crop, gecros
SOURCE: Cenlin He (NCAR/RAL)
DESCRIPTION OF CHANGES:
Th gecros crop model in Noah-MP (opt_crop=2) has been removed and no longer supported by the Noah-MP LSM team. The reasons are that (1) gecros is not well coupled into Noah-MP with some inconsistency in using Noah-MP variables (e.g., photosynthesis variable), (2) the Noah-MP LSM has decided to no longer maintain and support this crop option. So there is only one crop scheme in Noah-MP currently (opt_crop=1, Liu et al., 2016). More advanced crop schemes fully coupled with Noah-MP are under development too. Users would like to use the gecros scheme can refer to an older version of WRF.
ISSUE: For use when this PR closes an issue.
Fixes #123
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status developto get formatted list)Note: the following files are changed compared with WRF develop branch
M Registry/Registry.EM_COMMON
M Registry/Registry.NMM
M Registry/registry.dimspec
M Registry/registry.noahmp
M dyn_em/module_first_rk_step_part1.F
M dyn_em/start_em.F
M dyn_nmm/module_PHYSICS_CALLS.F
M dyn_nmm/start_domain_nmm.F
M main/depend.common
M phys/Makefile
M phys/module_physics_init.F
D phys/module_sf_gecros.F
M phys/module_sf_noahmpdrv.F
M phys/module_sf_noahmplsm.F
M phys/module_surface_driver.F
M run/README.namelist
TESTS CONDUCTED:
RELEASE NOTE: Remove the gecros crop option (opt_crop=2) in Noah-MP which is no longer supported.