Fix to saturation vapor pressure at low temperatures#1328
Merged
weiwangncar merged 1 commit intowrf-model:release-v4.2.2from Dec 29, 2020
hmorrison100:hmorrison100-morr-two-moment-sat-fix
Merged
Fix to saturation vapor pressure at low temperatures#1328weiwangncar merged 1 commit intowrf-model:release-v4.2.2from hmorrison100:hmorrison100-morr-two-moment-sat-fix
weiwangncar merged 1 commit intowrf-model:release-v4.2.2from
hmorrison100:hmorrison100-morr-two-moment-sat-fix
Conversation
weiwangncar
changed the title
Collaborator
|
@hmorrison100 I've edited the PR message in the box area near the top. Please feel free to make change. To edit the PR message, click on the '...' (it's a pull-down menu, which will give you an 'Edit' option) to the left of the (small) smiling face. I've also changed your code to be based on release-v4.2.2, instead of master branch. |
Collaborator
|
Is the value reasonably continuous at the limit of the two functions? |
Contributor
|
@weiwangncar @dudhia |
weiwangncar
approved these changes
Dec 29, 2020
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: saturation vapor pressure, Morrison double-moment scheme SOURCE: Hugh Morrison (NCAR) DESCRIPTION OF CHANGES: Problem: Current code gave unrealistically high saturation vapor pressures at T < -80 C. Solution: "function polysvp" in module_mp_morr_two_moment_aero.F and module_mp_morr_two_moment.F are modified to correct the problem. LIST OF MODIFIED FILES: M phys/module_mp_morr_two_moment_aero.F M phys/module_mp_morr_two_moment.F TESTS CONDUCTED: Idealized tests conduced by Morrison, the mods fix the problem. Jenkins tests have passed. RELEASE NOTE: Fix a problem with function polyqvp which gave unrealistically high saturation vapor pressures at T < -80 C.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: saturation vapor pressure, Morrison double-moment scheme
SOURCE: Hugh Morrison (NCAR)
DESCRIPTION OF CHANGES:
Problem:
Current code gave unrealistically high saturation vapor pressures at T < -80 C.
Solution:
"function polysvp" in module_mp_morr_two_moment_aero.F and module_mp_morr_two_moment.F are modified to correct the problem.
LIST OF MODIFIED FILES:
M phys/module_mp_morr_two_moment_aero.F
M phys/module_mp_morr_two_moment.F
TESTS CONDUCTED:
RELEASE NOTE: Fix a problem with function polyqvp which gave unrealistically high saturation vapor pressures at T < -80 C.