Add missing compiler name for Intel HSB/BDW config

[rcabell]

TYPE: bug fix

KEYWORDS: build, hydro

SOURCE: Ryan Cabell (NCAR)

DESCRIPTION OF CHANGES:
Problem:
Building coupled WRF/WRF Hydro models fails when choosing configuration INTEL (ifort/icc): HSW/BDW.

Solution:
Add missing ifort compiler with icc text to ARCH line for the HSW/BDW configuration. For completeness, the KNL MIC
configure stanza was also missing the same information, and has been updated.

Neither of these stanzas are involved in the traditional WRF code build, so there is no impact on users of the default WRF
atmosphere model.

ISSUE: For use when this PR closes an issue.
Fixes #1325

LIST OF MODIFIED FILES:
M arch/configure.defaults

TESTS CONDUCTED:

1. Modification causes WRF-Hydro build to complete successfully with the INTEL (ifort/icc): HSW/BDW configuration
2. Jenkins testing all positive

[davegill]

@rcabell
Ryan,
How does this mod impact the WRF Hydro build?

Yes, I agree that this mod should be included.

Also, the next stanza down should have the same treatment:

1879 
1880 ###########################################################
1881 #ARCH    Linux KNL x86_64 ppc64le i486 i586 i686 #serial smpar dmpar dm+sm
1882 #
1883 DESCRIPTION     =       INTEL ($SFC/$SCC): KNL MIC

But I do not see how this text is used during the build.

[davegill]

@rcabell
Ryan,
Happy New Year!
I have a question about this PR. I do not understand how the added text is assisting your build. Is this something specific to some pre-processing that you do?

[rcabell]

Hi Dave, Sorry this got lost in my email after I came off of PTO! Hopefully I can answer your question: There is a script in the Hydro code that is passed this ARCH string from arch/Config.pl in WRF and greps it for a compiler name. From this, it then translates this into a configuration option number in our custom build system. The ARCH string for this option didn’t have any compiler name it, so our grep was failing. Let me know if you need any additional information or clarification.

…

-Ryan

On Jan 7, 2021, at 2:17 PM, Dave Gill ***@***.***> wrote: @rcabell <https://github.com/rcabell> Ryan, Happy New Year! I have a question about this PR. I do not understand how the added text is assisting your build. Is this something specific to some pre-processing that you do? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1326 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHEYLTYXBQ5LLTZGQN2FUHDSYYQH7ANCNFSM4TRKXSMQ>.

[davegill]

@rcabell
Ryan,
OK, that makes sense now.

Please look at the stanza directly beneath the one that you modified. Would you add the same mod to that stanza also?

We are trying to get v422 out next week, and I would like to get this low hanging fruit included.
Thanks

[rcabell]

Please look at the stanza directly beneath the one that you modified. Would you add the same mod to that stanza also?

@davegill I'm not certain that WRF-Hydro is supported on KNL / MIC, but for the sake of consistency (and it's otherwise harmless), I've added the compiler name to that ARCH line as well.

[davegill]

@rcabell
Ryan,
I agree, the new addition is completely harmless. Once the jenkins tests come back, I'll merge this in.

[jw500]

This commit has broken the HSW/BDW build configuration. Rather than selecting the HSW/BDW option, the initial Intel compiler configuration is used instead. It looks like the #ARCH lines are now the same for these two options.