Skip to content

errfac.dat should only be applied once at the first outer-loop#1289

Closed
vikramjakhr wants to merge 1 commit intowrf-model:masterfrom
jamiebresch:bugfix/errfac_outerloop
Closed

errfac.dat should only be applied once at the first outer-loop#1289
vikramjakhr wants to merge 1 commit intowrf-model:masterfrom
jamiebresch:bugfix/errfac_outerloop

Conversation

@vikramjakhr
Copy link

modified: var/da/da_minimisation/da_get_innov_vector.inc

The first line should be a single-line "purpose" for this change

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: 5 to 10 words related to commit, separated by commas

SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member

DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?

Solution:
What was down algorithmically and in the source code to address the problem?

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

modified:   var/da/da_minimisation/da_get_innov_vector.inc
@vikramjakhr vikramjakhr requested a review from a team as a code owner September 15, 2020 08:30
@vikramjakhr
Copy link
Author

PR for testing jenkins issue

@vikramjakhr
Copy link
Author

test again

@vikramjakhr vikramjakhr reopened this Sep 15, 2020
@vikramjakhr
Copy link
Author

test

@vikramjakhr vikramjakhr reopened this Sep 15, 2020
@vikramjakhr
Copy link
Author

test

@vikramjakhr vikramjakhr reopened this Sep 15, 2020
@vikramjakhr
Copy link
Author

test

@vikramjakhr vikramjakhr reopened this Sep 15, 2020
@vikramjakhr
Copy link
Author

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants