Remove obsolescent and non-standard features in physics modules

[milancurcic]

TYPE: Bug fix

KEYWORDS: Fix, obsolescent, non-standard, features

SOURCE: Milan Curcic (University of Miami)

DESCRIPTION OF CHANGES:
Problem:
This PR removes or fixes some obsolescent and non-standard features in several physics modules which were
preventing WRF to be built with IBM XL v16.1.1 on Power9, as reported in #1270.

Solution:

• Replace amax1() occurrences with max()
• Explicitly cast literal constants that are passed to min() and max() intrinsics so that they are type and kind
  compatible with other arguments
• Replace calls to the non-standard flush() subroutine with the standard flush() statement.

ISSUE:
Fixes #1270

LIST OF MODIFIED FILES:
M phys/module_cu_mskf.F
M phys/module_cu_scalesas.F
M phys/module_dust_emis.F
M phys/module_mp_fast_sbm.F
M phys/module_mp_milbrandt2mom.F
M phys/module_mp_p3.F
M phys/module_mp_thompson.F
M phys/module_ra_goddard.F
M phys/module_shcu_deng.F

TESTS CONDUCTED:

1. These fixes were necessary to allow WRF to be built and run on IBM Power9 with the XL v16.1.1 compiler. The
   executables build in both single (./configure) and double (./configure -r8) precision modes.
2. Jenkins testing is all pass.

RELEASE NOTE: Several physics modules were updated to be more Fortran standard-conforming. This PR removes or fixes some obsolescent and non-standard features in several physics modules which were preventing WRF to be built with IBM XL v16.1.1 on Power9.

[dudhia]

Dave will need to confirm, but it looks fine to me and probably can be targeted for release 4.2.2.

[milancurcic]

Oops, I only now see that I based this off master. We can rebase it to release-v4.2.2 if needed.

[dudhia]

Should not be much difference. master is probably 4.2.1

…

On Mon, Aug 17, 2020 at 3:06 PM Milan Curcic ***@***.***> wrote: Oops, I only now see that I based this off master. We can rebase it to release-v4.2.2 if needed. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1273 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77DKY5GXW2ZMBBF5TN3SBGLTPANCNFSM4QCFQQFA> .

[dudhia]

should be sufficient to just change the target in the PR.

…

On Mon, Aug 17, 2020 at 3:07 PM Jimy Dudhia ***@***.***> wrote: Should not be much difference. master is probably 4.2.1 On Mon, Aug 17, 2020 at 3:06 PM Milan Curcic ***@***.***> wrote: > Oops, I only now see that I based this off master. We can rebase it to > release-v4.2.2 if needed. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <#1273 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEIZ77DKY5GXW2ZMBBF5TN3SBGLTPANCNFSM4QCFQQFA> > . >

[milancurcic]

@dudhia @weiwangncar @davegill Does this PR need any more care or is it good to go?

[davegill]

@milancurcic

Does this PR need any more care or is it good to go?

Milan,
Do your mods work when building with double precision? Since our compilers do not catch this, we rely on you.

> ./clean -a
> ./configure -r8
> ./compile em_real >& foo

[milancurcic]

@davegill Good call. -r8 triggers similar errors in other physics modules. Stand by for more fixes.

[milancurcic]

Both single and double precision modes now build. I updated the PR description with new files that are changed.

[weiwangncar]

I'm ok with this PR.

[weiwangncar]

@davegill @dudhia Any more comments on this PR? Shall I approve and merge it?

[dudhia]

I wonder if it should go to develop instead of 4.2.2

[weiwangncar]

@dudhia @davegill I can agree to that, making this PR to develop branch.

[davegill]

@weiwangncar @dudhia
Folks,
I think that this should be directed at the release-v4.2.2 branch, not develop. This is definitely a bug fix. I am OK with this, but I do not want to approve if you guys are still deciding which branch to use.

I removed the un-associated mod to the .gitignore file. This is now completely a fix for compiling on power9 with IBM's xl compiler.

[weiwangncar]

@davegill I have approved it. So I'm ok for this to go to 4.2.2.

[dudhia]

I just saw a bunch of other developers who might need to be notified for various physics options affected.

…

On Tue, Dec 29, 2020 at 2:14 PM weiwangncar ***@***.***> wrote: @davegill <https://github.com/davegill> I have approved it. So I'm ok for this to go to 4.2.2. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1273 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77BK74UWROPVSHSECR3SXJBCLANCNFSM4QCFQQFA> .

[davegill]

@dudhia

I just saw a bunch of other developers who might need to be notified for various physics options affected.

Is this a request to not merge the code?

[dudhia]

This is why I wasn’t sure

…

On Tue, Dec 29, 2020 at 4:28 PM Dave Gill ***@***.***> wrote: @dudhia <https://github.com/dudhia> I just saw a bunch of other developers who might need to be notified for various physics options affected. Is this a request to not merge the code? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1273 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77E7V6WNVR4F2LWXT7DSXJQ23ANCNFSM4QCFQQFA> .

[davegill]

@dudhia @weiwangncar
Jimy,
Understood.

I think that since these are bug fixes, we notify the developers to review this PR. There are some schemes that we can say that "we" own.

[JS-WRF-SBM]

@davegill @milancurcic @dudhia @weiwangncar

Folks, thanks for working on these corrections.
I'm OK with the changes for the phys/module_mp_fast_sbm.F scheme in this PR.

Koby

[gthompsnWRF]

@davegill I am fine with the changes. I see only one change to mp-thompson and 2 changes to module_dust_emis. I would think the latter file could just use all single-prec variables and skip all that casting to double that seems wasteful. Either way, it is no different to me. Thanks.

[llpcarson]

Looks ok to me (module_cu_scalesas.F )

[davegill]

@dudhia @weiwangncar
Folks,
We have heard back from almost all impacted. In addition to those above, Hugh, Janson, and Kiran sent "OK" emails. I say we go for it with these mods.

[weiwangncar]

I'm ok with this, and have already approved this PR.

[davegill]

@dudhia @weiwangncar
Jimy,
Wei has already approved this. Most of the impacted physics developers have given a thumbs up. This is OK to merge

[dudhia]

OK

…

On Wed, Jan 6, 2021 at 9:59 PM Dave Gill ***@***.***> wrote: @dudhia <https://github.com/dudhia> @weiwangncar <https://github.com/weiwangncar> Jimy, Wei has already approved this. Most of the impacted physics developers have given a thumbs up. This is OK to merge — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1273 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77C5QBOOLDT6STCTO3DSYU5T5ANCNFSM4QCFQQFA> .