Update PR commit message templates#1255
Merged
davegill merged 1 commit intowrf-model:release-v4.2.1from Jul 14, 2020
Merged
Conversation
TYPE: text only KEYWORDS: PR, commit message, template SOURCE: internal DESCRIPTION OF CHANGES: Problem: The older commit templates referred to WTF and had some singleton three quotes in a row (without a closing set of quotes). There was ambiguity in the tests conducted, and no reference to the jenkins results. Solution: Small text tweaks, just update expecations from contributors. The text for two templates is now consistent. LIST OF MODIFIED FILES: modified: .github/PULL_REQUEST_TEMPLATE modified: tools/commit_form.txt TESTS CONDUCTED: 1. No source changes, but jenkins will run.
kkeene44
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: text only
KEYWORDS: PR, commit message, template
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The older commit templates referred to WTF and had some singleton three quotes in a row (without
a closing set of quotes). There was ambiguity in the requests for what tests were to be conducted, and there
was no reference to the jenkins results.
Solution:
Small text tweaks, just update and clarify expectations from contributors. The text for the two templates is now
consistent.
LIST OF MODIFIED FILES:
modified: .github/PULL_REQUEST_TEMPLATE
modified: tools/commit_form.txt
TESTS CONDUCTED: