Skip to content

Update README.grid_fdda - add (max_dom) for rinblw#1248

Merged
davegill merged 3 commits intowrf-model:release-v4.2.1from
pengzimu:patch-1
Jul 15, 2020
Merged

Update README.grid_fdda - add (max_dom) for rinblw#1248
davegill merged 3 commits intowrf-model:release-v4.2.1from
pengzimu:patch-1

Conversation

@pengzimu
Copy link
Contributor

@pengzimu pengzimu commented Jul 10, 2020

TYPE: text only

KEYWORDS: readme, rinblw, max_dom

SOURCE: Peng Zimu (Peking University) and internal

DESCRIPTION OF CHANGES:
One of the FDDA capabilities for blending observations with the gridded simulation relies on the appropriate
observation density within a specified radius of influence, which is controlled by the option rinblw (km). To allow
for different observations on different nests, this option is defined in the Registry as a max_domains namelist entry.
Therefore this option should be specified for each individual domain. This PR:

  1. adds (max_dom) to rinblw in test/em_real/README.grid_fdda
  2. adds multiple columns for rinblw in test/em_real/examples.namelist.

For users with nested domains, before this mod, the WRF code returned:

Error in rinblw, please specify a reasonable value ***

This update to the documentation helps users to a priori correctly set rinblw for nested domains.

LIST OF MODIFIED FILES:
M test/em_real/examples.namelist
M test/em_real/README.grid_fdda

TESTS CONDUCTED:

  1. After setting rinblw for nested domains, the WRF with surface-analysis nudging can run successfully.
  2. Only README files changed, no tests required.

RELEASE NOTES: A modification to a couple of the README files, which helps users to correctly set rinblw when surface-analysis nudging is applied to nested domains. Previously, the rinblw was not consistently identified as a max_dom variable.

@smileMchen
Copy link
Collaborator

smileMchen commented Jul 14, 2020

This modification is correct and necessary. If no objection, I would like to approve this PR.

@davegill
Copy link
Contributor

@pengzimu

  1. Please fill in the rest of the PR commit message.
  2. Also, the test/em_real/examples.namelist should have rinblw in multiple columns
  3. Describe the before and after status of your run

@davegill
Copy link
Contributor

@smileMchen @pengzimu
Ming,
Let's get the PR message fixed, and the test/em_real/examples.namelist modified before the commit.

@smileMchen
Copy link
Collaborator

@davegill @pengzimu
I have changed examples.namelist and modified the PR message.

@davegill
Copy link
Contributor

@pengzimu @smileMchen
We would like your affiliation please, so that we may reference you in our release notes, and so that your name is on this commit message.

@pengzimu
Copy link
Contributor Author

@davegill @smileMchen
I have added my affiliation and test information to the PR commit message. And I also changed the word "observational nudging" to "surface-analysis nudging" in the release notes since the option rinblw belongs to surface-analysis nudging according to the test/em_real/examples.namelist.

@davegill
Copy link
Contributor

@pengzimu
Peng,
Did you get an email from jenkins? Maybe in your spam folder? If so, please include the text of that email in one of these comment boxes below the commit message.

@pengzimu
Copy link
Contributor Author

@davegill
Up to now I haven't found any email from jenkins in my inbox or spam folder.

@davegill davegill merged commit 2ebe4e9 into wrf-model:release-v4.2.1 Jul 15, 2020
@pengzimu pengzimu deleted the patch-1 branch July 15, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants