Release v4.2.1 Fire compile error

[MicroTed]

TYPE: bug fix

KEYWORDS: subroutine, end

SOURCE: Ted Mansell (NSSL), issue reported by Manuel Luis Aznar (University of La Laguna)

DESCRIPTION OF CHANGES:
Compilation error generated by a subroutine which has an "end" statement but does not have an
"end subroutine X" statement.

• Platform: Macos High Sierra (10.13)
• Compilers: Fortran: ifort Version 13.0.3.198 Build 20130606; cc: clang-1000.11.45.5
• MPI: Openmpi 2.1.2

ISSUE:
Fixes issue #1215 (Error in compiling WRF v4.2)

LIST OF MODIFIED FILES:
phys/module_fr_fire_phys.F

TESTS CONDUCTED:

1. Previously, the compiler complained about the syntax:

time mpif90 -f90=ifort -o module_fr_fire_phys.o -c -O3 -fp-model precise -w -ftz -align all -fno-alias -fno-common -FR -convert big_endian  [etc.]  module_fr_fire_phys.f90
module_fr_fire_phys.f90(755): error #6378: SUBROUTINE must be present on the end-subroutine-stmt of an internal or module subroutine
end
^
compilation aborted for module_fr_fire_phys.f90 (code 1)

Addition of "subroutine read_namelist_fire" resolved the error.

2. Jenkins test passed.

RELEASE NOTE: A compiler error was raised by ifort 13 for a fire module routine due to omission of the keyword "SUBROUTINE" in the "END SUBROUTINE" statement. This has been addressed.

[davegill]

@MicroTed
Ted,
Include the text from the jenkins test in one of these lower comment sections.

[MicroTed]

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 496e5f2, requested by: MicroTed for PR: #1223. For any query please send e-mail to David Gill.

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 19           18
Number of Builds       : 48           46
Number of Simulations  : 166           164        0
Number of Comparisons  : 105           104        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

[davegill]

@MicroTed
Ted,
In the "DESCRIPTION" section, would you list which compiler and version was having this trouble.

In the "TESTS CONDUCTED" section, would you provide the text-output from the compiler log that failed that highlights this trouble. Also in the "TESTS" section, would you add that the code now compiles with this change.

[MicroTed]

OK, I was wondering which "comment section" :D

[davegill]

@mlaznar
Please verify that this fix works for you, and provide that information in a comment.

[mlaznar]

I perform the compilation again and it was succesful, as a proof look at the attached build.log

build.log

[davegill]

@mlaznar
Thanks!
Would you please provide your name and affiliation for our release messages.

[mlaznar]

You are welcome Dave!!

My name is: Manuel Luis Aznar
As affiliation: If I understand what that mean, I will say I am working at a research group at the University of La Laguna called Grupo de Observación de la Tierra y de la Atmósfera (GOTA)

Thanks Dave

[davegill]

Approved