Minor changes to support FPT, static analysis regression test#1218
Closed
JCollinsSimCon wants to merge 5 commits intomasterfrom
Closed
Minor changes to support FPT, static analysis regression test#1218JCollinsSimCon wants to merge 5 commits intomasterfrom
JCollinsSimCon wants to merge 5 commits intomasterfrom
Conversation
TYPE: bug fix
KEYWORDS: remove conflict marker "<<<<<" and ">>>>"
SOURCE: Jan Mandel (CU Denver)
DESCRIPTION OF CHANGES:
In the surface driver, we have:
```
<<<<<<< HEAD
END IF
END IF
=======
ENDIF
ENDIF
>>>>>>> origin/master
```
LIST OF MODIFIED FILES:
M phys/module_surface_driver.F
TESTS CONDUCTED:
1. Jenkins auto testing is PASS
TYPE: new feature
KEYWORDS: WRFDA, AHI, Cloud detection
SOURCE: Deqin Li (Liaoning Meteorological Bureau of CMA/NCAR), Dongmei Xu (NUIST/NCAR), Jonathan Guerrette (NCAR).
DESCRIPTION OF CHANGES:
A cloud detection method is added for AHI radiance data assimilation based on an infrared-only cloud mask (CM) algorithm.
LIST OF MODIFIED FILES:
A: var/da/da_physics/da_trop_wmo.inc
A: var/da/da_radiance/mod_clddet_geoir.f90
M: Registry/registry.var
M: var/build/da.make
M: var/build/depend.txt
M: var/da/da_define_structures/da_define_structures.f90
M: var/da/da_physics/da_physics.f90
M: var/da/da_radiance/da_allocate_rad_iv.inc
M: var/da/da_radiance/da_crtm.f90
M: var/da/da_radiance/da_deallocate_radiance.inc
M: var/da/da_radiance/da_get_innov_vector_crtm.inc
M: var/da/da_radiance/da_initialize_rad_iv.inc
M: var/da/da_radiance/da_qc_ahi.inc
M: var/da/da_radiance/da_radiance.f90
M: var/da/da_radiance/da_radiance1.f90
M: var/da/da_radiance/da_read_obs_netcdf4ahi_jaxa.inc
M: var/da/da_radiance/da_setup_radiance_structures.inc
TESTS CONDUCTED:
WRFDA regression tests ran successfully with gnu/ifort+mpt on Cheyenne.
RELEASE NOTE: New capability for an IR-only cloud detection scheme for AHI radiance data assimilation.
Wu et al., 2020, Improving forecasts of a record-breaking rainstorm in Guangzhou by assimilating every 10-min AHI radiances with WRF 4DVAR. Atmospheric Research, 239, 104912.
Zhuge, X., Zou, X., 2016. Test of a modified infrared-only ABI cloud mask algorithm for
AHI radiance observations. J. Appl. Meteorol. Climatol. 55 (11), 2529–2546.
TYPE: new feature KEYWORDS: superobbing, cloud detection, cloud fraction, AHI SOURCE: Yali Wu (NCAR/MMM), Jonathan Guerrette (NCAR/MMM). DESCRIPTION OF CHANGES: This PR adds a new function of superobbing AHI radiances and retrieving cloud fraction based on AHI cloud detection results. The default namelist parameter `ahi_superob_halfwidth` is set to zero, which means no superobbing will be applied. ISSUE: no issue LIST OF MODIFIED FILES: M Registry/registry.var M var/da/da_define_structures/da_define_structures.f90 M var/da/da_monitor/da_rad_diags.f90 M var/da/da_radiance/da_allocate_rad_iv.inc M var/da/da_radiance/da_deallocate_radiance.inc M var/da/da_radiance/da_initialize_rad_iv.inc M var/da/da_radiance/da_qc_ahi.inc M var/da/da_radiance/da_radiance.f90 M var/da/da_radiance/da_radiance1.f90 M var/da/da_radiance/da_read_obs_netcdf4ahi_jaxa.inc M var/da/da_radiance/da_write_iv_rad_ascii.inc M var/da/da_radiance/da_write_oa_rad_ascii.inc TESTS CONDUCTED: This capability has been tested in generating one-month AHI obs files for MPAS-JEDI DA purpose. WRFDA regression tests passed.
davegill
changed the title
Contributor
|
@nikosspanakis |
Contributor
|
@brianfarrimond |
Contributor
|
@nbald |
Contributor
|
Using PR #1253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes to support "WRF_fpt_regression" static analysis regression test.
TYPE: New feature and bug fixes to support it.
KEYWORDS: Static analysis, Regression Test
SOURCE: John Collins, Edge Hill University and SimCon
DESCRIPTION OF CHANGES:
frame/Makefile changed so as not to delete XX*.f90 and yy*.f90. They are needed for the regression test. The temporary files are deleted by WRF/clean
Bug fixes which caused analysis problems:
dyn_em/module_first_rk_step_part1.F: Missing continuation character inserted line 782
external/io_grib2/bacio-1.3/bacio.F: Missing :: delimiters inserted
phys/module_bl_mynn.F: Duplicate + operator removed line 3030
phys/module_fr_fire_phys.F: end written for an internal routine changed to END SUBROUTINE
LIST OF MODIFIED FILES:
frame/Makefile
dyn_em/module_first_rk_step_part1.F
external/io_grib2/bacio-1.3/bacio.F
phys/module_bl_mynn.F
phys/module_fr_fire_phys.F
TESTS CONDUCTED: WTF tests not yet run. WRF static regression test WRF_fpt_regression run successfully (See http://simconglobal.com/wrf_regression_testing.html)
RELEASE NOTE: WRF static analysis regression test is now available, please see http://simconglobal.com/wrf_regression_testing.html