enhanced slope calculation at domain boundary for periodic BC#1217
Merged
kkeene44 merged 1 commit intowrf-model:release-v4.2.1from Jul 10, 2020
Merged
enhanced slope calculation at domain boundary for periodic BC#1217kkeene44 merged 1 commit intowrf-model:release-v4.2.1from
kkeene44 merged 1 commit intowrf-model:release-v4.2.1from
Conversation
Contributor
Matthias, |
Contributor
Author
|
Dave, |
dudhia
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: slope, periodic boundary conditions
SOURCE: Matthias Göbel (University of Innsbruck)
DESCRIPTION OF CHANGES: In the current WRF version the slope angle on the lateral boundaries of the domain is calculated differently than in the interior of the domain. For the former, forward or backward final differences are used, for the latter central finite differences. This can lead to different shortwave fluxes for equivalent locations in mountainous terrain.
For periodic boundary conditions, the terrain outside of the domain is known and set right before.
This enhancement implements central differences also for the domain boundary to get the same shortwave flux for equivalent locations.
ISSUE: Fixes #1008
LIST OF MODIFIED FILES: dyn_em/start_em.F
TESTS CONDUCTED:
RELEASE NOTE: for periodic boundary conditions the slope calculation for the lateral boundaries is made equivalent to the calculation for the interior of the domain