Skip to content

enhanced slope calculation at domain boundary for periodic BC#1217

Merged
kkeene44 merged 1 commit intowrf-model:release-v4.2.1from
matzegoebel:slope_calc
Jul 10, 2020
Merged

enhanced slope calculation at domain boundary for periodic BC#1217
kkeene44 merged 1 commit intowrf-model:release-v4.2.1from
matzegoebel:slope_calc

Conversation

@matzegoebel
Copy link
Contributor

@matzegoebel matzegoebel commented Jun 22, 2020

TYPE: enhancement

KEYWORDS: slope, periodic boundary conditions

SOURCE: Matthias Göbel (University of Innsbruck)

DESCRIPTION OF CHANGES: In the current WRF version the slope angle on the lateral boundaries of the domain is calculated differently than in the interior of the domain. For the former, forward or backward final differences are used, for the latter central finite differences. This can lead to different shortwave fluxes for equivalent locations in mountainous terrain.
For periodic boundary conditions, the terrain outside of the domain is known and set right before.
This enhancement implements central differences also for the domain boundary to get the same shortwave flux for equivalent locations.

ISSUE: Fixes #1008

LIST OF MODIFIED FILES: dyn_em/start_em.F

TESTS CONDUCTED:

RELEASE NOTE: for periodic boundary conditions the slope calculation for the lateral boundaries is made equivalent to the calculation for the interior of the domain

@davegill
Copy link
Contributor

@MATZE77

In the current WRF version the slope angle on the lateral boundaries of the domain is calculated differently than in the interior of the domain.

Matthias,
Is the calculation different only for periodic BCs?

@matzegoebel
Copy link
Contributor Author

Dave,
no, for all boundary conditions the calculation at the boundaries is different than in the interior.
This can be easily seen by the following lines from the code:
im1 = max(i-1,ids)
ip1 = min(i+1,ide-1)
grid%toposlpx(i,j)=(grid%ht(ip1,j)-grid%ht(im1,j))*grid%msftx(i,j)*grid%rdx/(ip1-im1)

Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

@kkeene44 kkeene44 merged commit 26c947c into wrf-model:release-v4.2.1 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants