Closed
Conversation
TYPE: bug fix KEYWORDS: NoahMP, opt_run option SOURCE: internal DESCRIPTION OF CHANGES: Problem: When running the NoahMP scheme with the ground water option (opt_run=5), the STEPWTD variable is initialized to a non-zero value. However when opt_run!=5, then the STEPWTD variable remains an uninitialized zero value. In the WRF source code, there are a couple of places where mod(x,STEPWTD) occurs. This causes an immediate "divide by zero" error in the first call to the surface driver. Solution: The IF test logic is re-arranged so that only when opt_run=5 (which means that STEPWTD is non-zero) is there a second IF test (using mod(x,STEPWTD)) to compute whether additional processing takes place. This modification was made separately to the develop branch after the branch release-v4.1.4 was released. See wrf-model#1101. The purpose of this modification is to allow users access to the latest v4.1.* branch that works with NoahMP. As this will be a single issue release, the README and inc/version_decl are also modified in preparation for the release of WRF release-v4.1.5 with this PR. LIST OF MODIFIED FILES: M dyn_em/module_first_rk_step_part1.F M phys/module_surface_driver.F M README M inc/version_decl TESTS CONDUCTED: Jenkins test PASS (positively tests NoahMP) Regression test in NCAR-MMM classroom machine PASS.
…l#1144) TYPE: bug fix KEYWORDS: remove conflict marker "<<<<<" and ">>>>" SOURCE: Jan Mandel (CU Denver) DESCRIPTION OF CHANGES: In the surface driver, we have: ``` <<<<<<< HEAD END IF END IF ======= ENDIF ENDIF >>>>>>> origin/master ``` LIST OF MODIFIED FILES: M phys/module_surface_driver.F TESTS CONDUCTED: 1. Jenkins auto testing is PASS
TYPE: new feature
KEYWORDS: WRFDA, AHI, Cloud detection
SOURCE: Deqin Li (Liaoning Meteorological Bureau of CMA/NCAR), Dongmei Xu (NUIST/NCAR), Jonathan Guerrette (NCAR).
DESCRIPTION OF CHANGES:
A cloud detection method is added for AHI radiance data assimilation based on an infrared-only cloud mask (CM) algorithm.
LIST OF MODIFIED FILES:
A: var/da/da_physics/da_trop_wmo.inc
A: var/da/da_radiance/mod_clddet_geoir.f90
M: Registry/registry.var
M: var/build/da.make
M: var/build/depend.txt
M: var/da/da_define_structures/da_define_structures.f90
M: var/da/da_physics/da_physics.f90
M: var/da/da_radiance/da_allocate_rad_iv.inc
M: var/da/da_radiance/da_crtm.f90
M: var/da/da_radiance/da_deallocate_radiance.inc
M: var/da/da_radiance/da_get_innov_vector_crtm.inc
M: var/da/da_radiance/da_initialize_rad_iv.inc
M: var/da/da_radiance/da_qc_ahi.inc
M: var/da/da_radiance/da_radiance.f90
M: var/da/da_radiance/da_radiance1.f90
M: var/da/da_radiance/da_read_obs_netcdf4ahi_jaxa.inc
M: var/da/da_radiance/da_setup_radiance_structures.inc
TESTS CONDUCTED:
WRFDA regression tests ran successfully with gnu/ifort+mpt on Cheyenne.
RELEASE NOTE: New capability for an IR-only cloud detection scheme for AHI radiance data assimilation.
Wu et al., 2020, Improving forecasts of a record-breaking rainstorm in Guangzhou by assimilating every 10-min AHI radiances with WRF 4DVAR. Atmospheric Research, 239, 104912.
Zhuge, X., Zou, X., 2016. Test of a modified infrared-only ABI cloud mask algorithm for
AHI radiance observations. J. Appl. Meteorol. Climatol. 55 (11), 2529–2546.
…release-v4.2 Conflicts:
Contributor
|
@YaliWu0219 |
Contributor
Author
@davegill Ok, I am going to close this test PR now. I updated related information in the comment lines in the real PR. At the time of merging the real PR, that information will be shown as the commits message. |
Contributor
Author
|
Close this test PR as all WRF regression tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: Test PR
KEYWORDS: superobbing, cloud detection, cloud fraction, AHI
SOURCE: Yali Wu (NCAR/MMM), Jonathan Guerrette (NCAR/MMM).
DESCRIPTION OF CHANGES: This PR is the same as #1173, but changed the base from
developtorelease-v4.2for testing if all regression tests can pass.ISSUE:
LIST OF MODIFIED FILES:
M Registry/registry.var
M var/build/da.make
M var/build/depend.txt
M var/da/da_define_structures/da_define_structures.f90
M var/da/da_monitor/da_rad_diags.f90
M var/da/da_physics/da_physics.f90
A var/da/da_physics/da_trop_wmo.inc
M var/da/da_radiance/da_allocate_rad_iv.inc
M var/da/da_radiance/da_crtm.f90
M var/da/da_radiance/da_deallocate_radiance.inc
M var/da/da_radiance/da_get_innov_vector_crtm.inc
M var/da/da_radiance/da_initialize_rad_iv.inc
M var/da/da_radiance/da_qc_ahi.inc
M var/da/da_radiance/da_radiance.f90
M var/da/da_radiance/da_radiance1.f90
M var/da/da_radiance/da_read_obs_netcdf4ahi_jaxa.inc
M var/da/da_radiance/da_setup_radiance_structures.inc
M var/da/da_radiance/da_write_iv_rad_ascii.inc
M var/da/da_radiance/da_write_oa_rad_ascii.inc
A var/da/da_radiance/mod_clddet_geoir.f90
TESTS CONDUCTED: Tested on Cheyenne. Also see descriptions in #1173.