Rename ESMF_FractionMod to WRF_ESMF_FractionMod

[milancurcic]

TYPE: bug fix

KEYWORDS: ESMF, ESMF_FractionMod, WRF_ESMF_FractionMod

SOURCE: Milan Curcic (University of Miami)

DESCRIPTION OF CHANGES:

Problem and solution documented here.

Currently, it is not possible to build and link WRF with a chosen ESMF library due to the name
conflicts between WRF internal ESMF interfaces with the intended ESMF library. I faced this problem
while I was trying to compile WRF with the ESMF library during LILAC project development for coupling
WRF with CTSM. This is specifically important for users and groups who would like to couple WRF
with other models using ESMF infrastructure. This issue can be resolved by either updating WRF to
use the new ESMF time manager interface or renaming all of WRF's internal ESMF interfaces to avoid
name collisions when linking with the intended ESMF library.

ISSUE: Fixes #1065.

LIST OF MODIFIED FILES:
M external/esmf_time_f90/ESMF_Fraction.F90
M external/esmf_time_f90/ESMF_Mod.F90
M external/esmf_time_f90/ESMF_TimeInterval.F90
M external/esmf_time_f90/Meat.F90

TESTS CONDUCTED: Compiled in em_real mode. Tested using the program mentioned here. Otherwise, I don't have the tooling set up for regression tests. Can you please run them for me?

[davegill]

@negin513
Negin,
Would you see if this PR continues to allow your CTSM code to build with WRF.

[davegill]

@milancurcic
Milan,
Would you post the text of the email from Jenkins (not the attachment)? I do not know why your PR failed. I ran a couple of tests locally and it seems OK.

[milancurcic]

Should I have received an email from Jenkins? I didn't.

[negin513]

@davegill Thanks for checking with me. It seems like this PR does not cause any conflicts for building CTSM code with WRF.

@milancurcic Thanks for the PR and code update.

[davegill]

Not sure what is going on with the failure. I cloned this repo and ran a regression test - all PASS.
#1164 "Test2"

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 35fe35bc10345cb75a68ccd896abf75ba492a9ba, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1164. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 18           18
    Number of Builds       : 47           47
    Number of Simulations  : 167           167        0
    Number of Comparisons  : 107           107        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

[davegill]

Ha, closed the wrong one!

[davegill]

@milancurcic
Milan,
I have moved your PR so that I issued it. I do not know why you got a red X for failure. We do not want to merge that into the repo. My tests are all PASS, using your exact mods.

I am closing this PR to use the identical mods in #1164

[milancurcic]

Sounds good, thanks, look forward to the release.