New default setting for RRTMG FAST and RRTMG KIAPS: no compile#1091
Merged
davegill merged 1 commit intowrf-model:developfrom Feb 12, 2020
Merged
New default setting for RRTMG FAST and RRTMG KIAPS: no compile#1091davegill merged 1 commit intowrf-model:developfrom
davegill merged 1 commit intowrf-model:developfrom
Conversation
TYPE: enhancement KEYWORDS: RRTMG, FAST, KIAPS, postamble, cpp SOURCE: internal DESCRIPTION OF CHANGES: Problem: The WRF code with the GNU compilers (from 6.3.* inclusive to anything before 9.1.0) will sometimes fail to compile. The error is listed as an "internal compiler error". The two RRTMG schemes (FAST and KIAPS) are the standard causes for GNU failing to compile the WRF code successfully. Solution: The following two mods were previously made to the WRF source code: 1. commit 17b5ac4, PR wrf-model#517 "KLUGE: RRTMG FAST + GNU > 6.3.0 is an internal compiler error" 2. commit a83c7cb, PR wrf-model#1084 "KLUGE - Option to avoid building RRTMK due to GNU problem" This new PR just resests the default settings from "always build these schemes" to "never build these schemes". LIST OF MODIFIED FILES: modified: arch/postamble TESTS CONDUCTED: 1. The logic to disable the RRTMG FAST scheme has been in place for more than 18 months. 2. Actually disabling the build of RRTMG FAST has been tested hundreds of times with the combination of the automated Jenkins regression test and the NCAR-only classroom tests. 3. The KIAPS infrastructure has been tested with both the automated Jenkins test and the NCAR classroom regression tests. RELEASE NOTE: The default setting for the WRF model is to NOT compile either of the two derivative RRTMG schemes: FAST or KIAPS. These codes break the GNU compiler (v6.3.0 through v8.*). To re-enable the schemes, modify the `configure.wrf`file after running the `./configure` command. Replace the "zero" values with "ones" in the lines `-DBUILD_RRTMG_FAST=0` or -DBUILD_RRTMK=0`. This is a compile-time modification.
Contributor
Author
|
@weiwangncar |
Collaborator
|
@davegill Thanks and I'm good with this change. |
kkeene44
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: RRTMG, FAST, KIAPS, postamble, cpp
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The WRF code with the GNU compilers (from 6.3.* inclusive to anything before 9.1.0) will
sometimes fail to compile. The error is listed as an "internal compiler error". The two RRTMG
schemes (FAST and KIAPS) are the standard causes for GNU failing to compile the WRF
code successfully.
Solution:
The following two mods were previously made to the WRF source code:
This new PR just resests the default settings from "always build these schemes" to "never
build these schemes".
LIST OF MODIFIED FILES:
modified: arch/postamble
TESTS CONDUCTED:
the combination of the automated Jenkins regression test and the NCAR-only classroom
tests.
the NCAR classroom regression tests.
RELEASE NOTE: The default setting for the WRF model is to NOT compile either of the two derivative RRTMG schemes: FAST or KIAPS. These codes break the GNU compiler (v6.3.0 through v8.*). To re-enable the schemes, modify the
configure.wrffile after running the./configurecommand. Replace the "zero" values with "ones" in the lines-DBUILD_RRTMG_FAST=0or-DBUILD_RRTMK=0. This is a compile-time modification.