Skip to content

CODE REVIEW ONLY: WRF-TEB integration #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmey wants to merge 1 commit into from
Closed

CODE REVIEW ONLY: WRF-TEB integration #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 73 additions & 11 deletions Registry/Registry.EM_COMMON
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions Registry/registry.dimspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ dimspec snly 2 namelist=num_snow_layers z snow_layers
dimspec l 2 namelist=num_soil_layers z soil_layers
dimspec snsl 2 namelist=num_snso_layers z snso_layers

dimspec teb_flly 2 namelist=teb_num_floor_layers z teb_floor_layers
dimspec teb_rdly 2 namelist=teb_num_road_layers z teb_road_layers
dimspec teb_roly 2 namelist=teb_num_roof_layers z teb_roof_layers
dimspec teb_waly 2 namelist=teb_num_wall_layers z teb_wall_layers
dimspec teb_snly 2 namelist=teb_num_snow_layers z teb_snow_layers

dimspec umap0 2 namelist=num_urban_ndm z num_urban_ndm
dimspec umap1 2 namelist=urban_map_zrd z urban_map_zrd
dimspec umap2 2 namelist=urban_map_zwd z urban_map_zwd
Expand Down
44 changes: 44 additions & 0 deletions dyn_em/module_first_rk_step_part1.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,50 @@ SUBROUTINE first_rk_step_part1 ( grid , config_flags &
& ,SF_BEP=grid%sf_bep,VL_BEP=grid%vl_bep &
& ,A_E_BEP=grid%a_e_bep,B_E_BEP=grid%b_e_bep,DLG_BEP=grid%dlg_bep &
& ,DL_U_BEP=grid%dl_u_bep &
!
! BEGIN: Optional urban for TEB
& ,teb_test_integration=grid%teb_test_integration &
& ,teb_num_snow_layers=grid%teb_num_snow_layers &
& ,teb_num_road_layers=grid%teb_num_road_layers &
& ,teb_num_roof_layers=grid%teb_num_roof_layers &
& ,teb_num_wall_layers=grid%teb_num_wall_layers &
& ,teb_num_floor_layers=grid%teb_num_floor_layers &
& ,TEB_TI_BLD=grid%TEB_TI_BLD &
& ,TEB_T_CANYON=grid%TEB_T_CANYON, TEB_Q_CANYON=grid%TEB_Q_CANYON &
& ,TEB_WS_ROOF=grid%TEB_WS_ROOF, TEB_WS_ROAD=grid%TEB_WS_ROAD &
& ,TEB_WSNOW_ROOF=grid%TEB_WSNOW_ROOF, TEB_TSNOW_ROOF=grid%TEB_TSNOW_ROOF &
& ,TEB_RSNOW_ROOF=grid%TEB_RSNOW_ROOF, TEB_ASNOW_ROOF=grid%TEB_ASNOW_ROOF &
& ,TEB_TSSNOW_ROOF=grid%TEB_TSSNOW_ROOF, TEB_ESNOW_ROOF=grid%TEB_ESNOW_ROOF &
& ,TEB_WSNOW_ROAD=grid%TEB_WSNOW_ROAD, TEB_TSNOW_ROAD=grid%TEB_TSNOW_ROAD &
& ,TEB_RSNOW_ROAD=grid%TEB_RSNOW_ROAD, TEB_ASNOW_ROAD=grid%TEB_ASNOW_ROAD &
& ,TEB_TSSNOW_ROAD=grid%TEB_TSSNOW_ROAD, TEB_ESNOW_ROAD=grid%TEB_ESNOW_ROAD &
& ,TEB_T_WIN1=grid%TEB_T_WIN1, TEB_T_WIN2=grid%TEB_T_WIN2 &
& ,TEB_AUX_MAX=grid%TEB_AUX_MAX, TEB_THER_PRODC_DAY=grid%TEB_THER_PRODC_DAY &
& ,TEB_QI_BLD=grid%TEB_QI_BLD &
& ,TEB_T_FLOOR=grid%TEB_T_FLOOR, TEB_T_MASS=grid%TEB_T_MASS &
& ,TEB_T_ROAD=grid%TEB_T_ROAD, TEB_T_ROOF=grid%TEB_T_ROOF &
& ,TEB_T_WALL_A=grid%TEB_T_WALL_A, TEB_T_WALL_B=grid%TEB_T_WALL_B &
& ,TEB_HVAC_COOL=grid%TEB_HVAC_COOL, TEB_HVAC_HEAT=grid%TEB_HVAC_HEAT &
& ,TEB_THER_PROD_PANEL=grid%TEB_THER_PROD_PANEL &
& ,TEB_PHOT_PROD_PANEL=grid%TEB_PHOT_PROD_PANEL &
& ,TEB_TSK_RURAL=grid%TEB_TSK_RURAL &
!
! BEGIN: INPUT quantities used for evaluating WRF-TEB with TEB OFFLINE
& ,TEB_INPUT_TA=grid%TEB_INPUT_TA &
& ,TEB_INPUT_PS=grid%TEB_INPUT_PS &
& ,TEB_INPUT_QA=grid%TEB_INPUT_QA &
& ,TEB_INPUT_WIND=grid%TEB_INPUT_WIND &
& ,TEB_INPUT_DIR=grid%TEB_INPUT_DIR &
& ,TEB_INPUT_DIR_SW=grid%TEB_INPUT_DIR_SW &
& ,TEB_INPUT_SCA_SW=grid%TEB_INPUT_SCA_SW &
& ,TEB_INPUT_LW=grid%TEB_INPUT_LW &
& ,TEB_INPUT_RAIN=grid%TEB_INPUT_RAIN &
& ,TEB_INPUT_SNOW=grid%TEB_INPUT_SNOW &
& ,TEB_INPUT_DIR_CO2=grid%TEB_INPUT_DIR_CO2 &
! END: INPUT quantities used for evaluating WRF-TEB with TEB OFFLINE
!
! END: Optional urban for TEB
!
& ,CMR_SFCDIF=grid%cmr_sfcdif, CHR_SFCDIF=grid%chr_sfcdif & !I/O urban
& ,CMC_SFCDIF=grid%cmc_sfcdif, CHC_SFCDIF=grid%chc_sfcdif & !I/O urban
& ,CMGR_SFCDIF=grid%cmgr_sfcdif, CHGR_SFCDIF=grid%chgr_sfcdif & !I/O urban
Expand Down
2 changes: 1 addition & 1 deletion dyn_em/module_initialize_real.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3060,7 +3060,7 @@ SUBROUTINE init_domain_rk ( grid &

! Split NUDAPT Urban Parameters

IF ( ( config_flags%sf_urban_physics == 1 ) .OR. ( config_flags%sf_urban_physics == 2 ) .OR. ( config_flags%sf_urban_physics == 3 ) ) THEN
IF ( ( config_flags%sf_urban_physics == 1 ) .OR. ( config_flags%sf_urban_physics == 2 ) .OR. ( config_flags%sf_urban_physics == 3 ) .OR. ( config_flags%sf_urban_physics == 4 ) ) THEN
Comment thread
dmey marked this conversation as resolved.
DO j = jts , MIN(jde-1,jte)
DO i = its , MIN(ide-1,ite)
IF ( MMINLU == 'NLCD40' .OR. MMINLU == 'MODIFIED_IGBP_MODIS_NOAH') THEN
Expand Down
18 changes: 18 additions & 0 deletions dyn_em/start_em.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,24 @@ SUBROUTINE start_domain_em ( grid, allowed_to_read &
grid%A_E_BEP,grid%B_U_BEP,grid%B_V_BEP,grid%B_T_BEP, & !multi-layer urban
grid%B_Q_BEP,grid%B_E_BEP,grid%DLG_BEP, & !multi-layer urban
grid%DL_U_BEP,grid%SF_BEP,grid%VL_BEP, & !multi-layer urban
! optional urban for TEB
grid%teb_num_snow_layers, &
grid%teb_num_road_layers, &
grid%teb_num_roof_layers, &
grid%teb_num_wall_layers, &
grid%teb_num_floor_layers, &
grid%TEB_TI_BLD, &
grid%TEB_T_CANYON, grid%TEB_Q_CANYON, &
grid%TEB_WS_ROOF, grid%TEB_WS_ROAD, &
grid%TEB_WSNOW_ROOF, grid%TEB_TSNOW_ROOF, grid%TEB_RSNOW_ROOF, grid%TEB_ASNOW_ROOF, &
grid%TEB_TSSNOW_ROOF, grid%TEB_ESNOW_ROOF, &
grid%TEB_WSNOW_ROAD, grid%TEB_TSNOW_ROAD, grid%TEB_RSNOW_ROAD, grid%TEB_ASNOW_ROAD, &
grid%TEB_TSSNOW_ROAD, grid%TEB_ESNOW_ROAD, &
grid%TEB_T_WIN1, grid%TEB_T_WIN2, grid%TEB_AUX_MAX, grid%TEB_THER_PRODC_DAY, &
grid%TEB_QI_BLD, grid%TEB_T_FLOOR, grid%TEB_T_MASS, &
grid%TEB_T_ROAD, grid%TEB_T_ROOF, grid%TEB_T_WALL_A, grid%TEB_T_WALL_B, &
grid%TEB_TSK_RURAL, &
! end for TEB
grid%TML,grid%T0ML,grid%HML,grid%H0ML,grid%HUML,grid%HVML,grid%TMOML, & !Optional oml
grid%lakedepth2d, grid%savedtke12d, grid%snowdp2d, grid%h2osno2d, & !lake
grid%snl2d, grid%t_grnd2d, grid%t_lake3d, grid%lake_icefrac3d, & !lake
Expand Down
Loading