Skip to content

Fix comments in hybrid coordinate registry#1051

Merged
davegill merged 2 commits intowrf-model:release-v4.1.4from
davegill:hyb_comments
Jan 21, 2020
Merged

Fix comments in hybrid coordinate registry#1051
davegill merged 2 commits intowrf-model:release-v4.1.4from
davegill:hyb_comments

Conversation

@davegill
Copy link
Contributor

@davegill davegill commented Dec 30, 2019

TYPE: text only

KEYWORDS: hybrid comments

SOURCE: Found by Kezhen Chong (Georgia Institute of Technology), fixed internally

DESCRIPTION OF CHANGES:
Modify the comments in registry.hyb_coord to correctly define c4f and c4h. Originally, the value
of the pressure at the model lid (ptop) was included in the description of the computation of
the C4F and C4H 1d arrays as an added term. Following is the source code showing no such term.

   !  c4 is a function of c3 and eta.

   DO k=1, kde
      c4f(k) = ( znw(k) - c3f(k) ) * ( p1000mb - p_top )
   ENDDO

   !  Now on half levels, just add up and divide by 2 (for c3h).  Use (eta-c3)*(p00-pt) for c4 on half levels.

   DO k=1, kde-1
      c4h(k) = ( znu(k) - c3h(k) ) * ( p1000mb - p_top )
   ENDDO

ISSUE:
Fixes #1050

LIST OF MODIFIED FILES:
modified: Registry/registry.hyb_coord

TESTS CONDUCTED:

  • Text only in comment in a registry file, no tests required.

```
   !  c4 is a function of c3 and eta.

   DO k=1, kde
      c4f(k) = ( znw(k) - c3f(k) ) * ( p1000mb - p_top )
   ENDDO

   !  Now on half levels, just add up and divide by 2 (for c3h).  Use (eta-c3)*(p00-pt) for c4 on half levels.

   DO k=1, kde-1
      c4h(k) = ( znu(k) - c3h(k) ) * ( p1000mb - p_top )
   ENDDO
```

Changes to be committed:
modified:   registry.hyb_coord
@davegill davegill requested a review from a team as a code owner December 30, 2019 15:50
@davegill davegill changed the title Clean up comments on c4 Fix registry comments on c4f and c4h Dec 30, 2019
@davegill
Copy link
Contributor Author

@kchong75

  1. Please provide your name and affiliation for our commit message.
  2. Would you verify if this PR corrects the problem.

@kchong75
Copy link

Also, at the 4th line of registry.hyb_coord, it is "Pc = Pds - Pt", according to the variable definition below, should it be "Pc + Pcb = Pds - Pt" ?
Thank you!

@davegill
Copy link
Contributor Author

@kchong75
Would you please provide your name and affiliation so that we credit you in our release message.

@davegill davegill changed the title Fix registry comments on c4f and c4h Fix comments in hybrid coordinate registry Jan 13, 2020
@kchong75
Copy link

kchong75 commented Jan 13, 2020 via email

@davegill davegill merged commit b7135f9 into wrf-model:release-v4.1.4 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants