Fix comments in hybrid coordinate registry#1051
Merged
davegill merged 2 commits intowrf-model:release-v4.1.4from Jan 21, 2020
Merged
Fix comments in hybrid coordinate registry#1051davegill merged 2 commits intowrf-model:release-v4.1.4from
davegill merged 2 commits intowrf-model:release-v4.1.4from
Conversation
```
! c4 is a function of c3 and eta.
DO k=1, kde
c4f(k) = ( znw(k) - c3f(k) ) * ( p1000mb - p_top )
ENDDO
! Now on half levels, just add up and divide by 2 (for c3h). Use (eta-c3)*(p00-pt) for c4 on half levels.
DO k=1, kde-1
c4h(k) = ( znu(k) - c3h(k) ) * ( p1000mb - p_top )
ENDDO
```
Changes to be committed:
modified: registry.hyb_coord
Contributor
Author
|
|
Also, at the 4th line of registry.hyb_coord, it is "Pc = Pds - Pt", according to the variable definition below, should it be "Pc + Pcb = Pds - Pt" ? |
Contributor
Author
|
@kchong75 |
|
Hi Dave,
I am Kezhen Chong from Georgia Institute of Technology.
Thank you,
Kezhen
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Dave Gill <notifications@github.com>
Sent: Monday, January 13, 2020 2:00:49 PM
To: wrf-model/WRF <WRF@noreply.github.com>
Cc: Chong, Kezhen <kezhenchong@gatech.edu>; Mention <mention@noreply.github.com>
Subject: Re: [wrf-model/WRF] Fix registry comments on c4f and c4h (#1051)
@kchong75<https://github.com/kchong75>
Would you please provide your name and affiliation so that we credit you in our release message.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1051?email_source=notifications&email_token=ALSX5RYZNWMLISOST2XYLLTQ5S26DA5CNFSM4KBNYWX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZ4ILI#issuecomment-573817901>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALSX5R4GCDCJIQRD745JHKTQ5S26DANCNFSM4KBNYWXQ>.
|
kkeene44
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: text only
KEYWORDS: hybrid comments
SOURCE: Found by Kezhen Chong (Georgia Institute of Technology), fixed internally
DESCRIPTION OF CHANGES:
Modify the comments in registry.hyb_coord to correctly define c4f and c4h. Originally, the value
of the pressure at the model lid (ptop) was included in the description of the computation of
the C4F and C4H 1d arrays as an added term. Following is the source code showing no such term.
ISSUE:
Fixes #1050
LIST OF MODIFIED FILES:
modified: Registry/registry.hyb_coord
TESTS CONDUCTED: