HWRF fixes: build = replicated symbol; run = link in look-up tables#1049
Merged
davegill merged 3 commits intowrf-model:release-v4.1.4from Jan 21, 2020
Merged
HWRF fixes: build = replicated symbol; run = link in look-up tables#1049davegill merged 3 commits intowrf-model:release-v4.1.4from
davegill merged 3 commits intowrf-model:release-v4.1.4from
Conversation
Link in all of the look-up tables to test/nmm_real directory SMOOTHER - cannot be a LABEL and a SUBROUTINE name Changes to be committed: modified: Makefile modified: external/RSL_LITE/module_dm.F
Contributor
|
Thanks for updating these, the run-dir links are likely overkill, since many of those options are not used/tested with HWRF, but this is a simple fix. |
Contributor
Author
|
@llpcarson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: HWRF, build, run
SOURCE: internal
DESCRIPTION OF CHANGES:
To get the HWRF code to build and run the regression test cases, two changes are required:
Build
There is a replicated symbol in subroutine feedback_domain_nmm_part2: SMOOTHER. This
named symbol cannot be both a LABEL and the name of a called SUBROUTINE within
a single subprogram unit (subroutine or function). Just a quick misspelling of SMOOTHR works
wonders.
Run
Link in (ln -sf) all of the look-up tables to the test/nmm_real directory in the last step of the build
process. Most of the run-time-required links to physics data files were not originally in place.
LIST OF MODIFIED FILES:
modified: Makefile
modified: external/RSL_LITE/module_dm.F
TESTS CONDUCTED: