Skip to content

HWRF fixes: build = replicated symbol; run = link in look-up tables#1049

Merged
davegill merged 3 commits intowrf-model:release-v4.1.4from
davegill:HWRF
Jan 21, 2020
Merged

HWRF fixes: build = replicated symbol; run = link in look-up tables#1049
davegill merged 3 commits intowrf-model:release-v4.1.4from
davegill:HWRF

Conversation

@davegill
Copy link
Contributor

@davegill davegill commented Dec 27, 2019

TYPE: bug fix

KEYWORDS: HWRF, build, run

SOURCE: internal

DESCRIPTION OF CHANGES:
To get the HWRF code to build and run the regression test cases, two changes are required:

Build

There is a replicated symbol in subroutine feedback_domain_nmm_part2: SMOOTHER. This
named symbol cannot be both a LABEL and the name of a called SUBROUTINE within
a single subprogram unit (subroutine or function). Just a quick misspelling of SMOOTHR works
wonders.

Run

Link in (ln -sf) all of the look-up tables to the test/nmm_real directory in the last step of the build
process. Most of the run-time-required links to physics data files were not originally in place.

LIST OF MODIFIED FILES:
modified: Makefile
modified: external/RSL_LITE/module_dm.F

TESTS CONDUCTED:

  • Without build mod (replicated symbol), code does not build with GNU
  • Without run mod (linked-in look-up tables), the code does not run regression tests
  • With both mods, the code builds and runs.
  • Regression test is now in place for HWRF.

Link in all of the look-up tables to test/nmm_real directory
SMOOTHER - cannot be a LABEL and a SUBROUTINE name

Changes to be committed:
modified:   Makefile
modified:   external/RSL_LITE/module_dm.F
@davegill davegill requested a review from a team as a code owner December 27, 2019 00:17
@davegill davegill changed the title HWRF Fixes HWRF fixes: build = replicated symbol; run = link in look-up tables Dec 27, 2019
@llpcarson
Copy link
Contributor

Thanks for updating these, the run-dir links are likely overkill, since many of those options are not used/tested with HWRF, but this is a simple fix.

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@davegill
Copy link
Contributor Author

@llpcarson
Laurie,
FYI: these mods get us a working HWRF in the repo.

@davegill davegill merged commit 0ffa927 into wrf-model:release-v4.1.4 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants