Fix for Deng shallow combined with other subgrid cloud options

[dudhia]

TYPE: bug fix

KEYWORDS: Deng shallow, radiation-driver clouds

SOURCE: internal and Pedro Jimenez

DESCRIPTION OF CHANGES:
Line qc_save = qc must be removed from Deng shallow section of radiation driver because it may save qc that is already updated by other physics that have radiation feedback, e.g. icloud, cu or bl. Leads to error when combining Deng shallow with such options (already not recommended with cumulus scheme). qc_save was already set for all options earlier.

LIST OF MODIFIED FILES:
phys/module_radiation_driver.F

TESTS CONDUCTED:
This fix has been tested by Pedro in WRF-Solar.
No regtests yet.
Test shows impact when Deng shcu is run with sub-grid clouds from MYNN icloud_bl=1. Left fixed, right old. Higher cloud fraction which leads to reduced surface shortwave compared to corrected code.
[Note that a later bug fix will not allow this combination, but fix applies to Deng shcu with sub-grid clouds from cumulus schemes and icloud=3 too].

RELEASE NOTE:
Deng shallow scheme fix for when combined with other sub-grid cloud schemes (e.g. non-microphysics options that have radiation feedback). This would have added these clouds to microphysics at each step instead of removing them after radiation. (provided by Pedro Jimenez).

[weiwangncar]

@dudhia Would this error lead to incorrect surface temperature as well as surface rainfall? If so, could you add it to the message?

[dudhia]

I have not seen a run with this error. I will ask, Jimy

…

On Tue, Dec 17, 2019 at 2:47 PM weiwangncar ***@***.***> wrote: @dudhia <https://github.com/dudhia> Would this error lead to incorrect surface temperature as well as surface rainfall? If so, could you add it to the message? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1043?email_source=notifications&email_token=AEIZ77BKY4QKBAFUAOESLPTQZFCGBA5CNFSM4J4BC7EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEB7OA#issuecomment-566763448>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77D6XQWZKUTNB3VKBDLQZFCGBANCNFSM4J4BC7EA> .

[davegill]

@weiwangncar @dudhia
Can we get a 👍 or 👎 on this PR?

[dudhia]

probably need to make sure at least one regtest included this shcu option.

[davegill]

@dudhia @weiwangncar

Line qc_save = qc must be removed from Deng shallow section of radiation driver because it may save qc that is already updated by other physics that have radiation feedback

Can we fix this line. We should not have may save. Either it does save it incorrectly, or it does not.

[dudhia]

It is "may" because it depends on what other options were chosen. A new check-a-mundo is also preventing this combination anyway. Jimy

…

On Tue, Jan 28, 2020 at 9:05 AM Dave Gill ***@***.***> wrote: @dudhia <https://github.com/dudhia> @weiwangncar <https://github.com/weiwangncar> Line qc_save = qc must be removed from Deng shallow section of radiation driver because it may save qc that is already updated by other physics that have radiation feedback Can we fix this line. We should not have *may save*. Either it does save it incorrectly, or it does not. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1043?email_source=notifications&email_token=AEIZ77BGH7OBRXTE3BH5ULTRABJWLA5CNFSM4J4BC7EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKD4VQA#issuecomment-579324608>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77B4QYVKQV23SPOBJQDRABJWLANCNFSM4J4BC7EA> .