Skip to content

Remove pop/push communicator on non MPI runs#1038

Merged
davegill merged 5 commits intowrf-model:release-v4.1.4from
davegill:fire_pops
Jan 21, 2020
Merged

Remove pop/push communicator on non MPI runs#1038
davegill merged 5 commits intowrf-model:release-v4.1.4from
davegill:fire_pops

Conversation

@davegill
Copy link
Contributor

@davegill davegill commented Dec 14, 2019

TYPE:bug fix

KEYWORDS: fire, pop, push, communicator

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
WRF gets into a state where the code tries to pop or push a stack of communicators. This should
not happen when doing a Serial or OpenMP build.

Here is the example error message we get with a push on OpenMP:

-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    5489
pop_communicators_for_domain on empty stack
-------------------------------------------

And here is the example error message with a pop with OpenMP:

-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    5464
push_communicators_for_domain would excede stacksize
-------------------------------------------

Solution:
This problem only occurs with Serial or OpenMP builds. The communicators are only required for
distributed memory MPI jobs. Therefore, put an ifdef around the routine that handles pops
and pushes of the the communicator stack.

LIST OF MODIFIED FILES:
modified: external/RSL_LITE/module_dm.F

TESTS CONDUCTED:

  • Auto regression is HAPPY!

Changes to be committed:
modified:   external/RSL_LITE/module_dm.F
@davegill davegill requested a review from a team as a code owner December 14, 2019 16:42
@davegill davegill changed the title Remove "pop communicator" on non MPI runs Remove pop/push communicator on non MPI runs Dec 20, 2019
@davegill
Copy link
Contributor Author

@mgduda
No review required, but this PR made me think of you.

Screen Shot 2019-12-20 at 4 56 25 PM

@kkeene44
Copy link
Collaborator

@davegill
I modified the commit message. In this line:
"WRF gets into a state where the code tries to pop or push a stack of communicators."
You originally said "pop or pop." I assume it should be as it is now stated above. This is causing a repo test, though, so it currently says we are waiting on some checks - not sure if you want to squash/merge this yet.

@davegill davegill merged commit d61195a into wrf-model:release-v4.1.4 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants