Remove pop/push communicator on non MPI runs#1038
Merged
davegill merged 5 commits intowrf-model:release-v4.1.4from Jan 21, 2020
Merged
Remove pop/push communicator on non MPI runs#1038davegill merged 5 commits intowrf-model:release-v4.1.4from
davegill merged 5 commits intowrf-model:release-v4.1.4from
Conversation
Changes to be committed: modified: external/RSL_LITE/module_dm.F
Contributor
Author
|
@mgduda |
kkeene44
approved these changes
Jan 21, 2020
Collaborator
|
@davegill |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TYPE:bug fix
KEYWORDS: fire, pop, push, communicator
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
WRF gets into a state where the code tries to pop or push a stack of communicators. This should
not happen when doing a Serial or OpenMP build.
Here is the example error message we get with a push on OpenMP:
And here is the example error message with a pop with OpenMP:
Solution:
This problem only occurs with Serial or OpenMP builds. The communicators are only required for
distributed memory MPI jobs. Therefore, put an ifdef around the routine that handles pops
and pushes of the the communicator stack.
LIST OF MODIFIED FILES:
modified: external/RSL_LITE/module_dm.F
TESTS CONDUCTED: