Bug fix for calculating effective radius of rain, snow, and graupel#1027
Merged
liujake merged 1 commit intorelease-v4.1.4from Dec 4, 2019
Merged
Bug fix for calculating effective radius of rain, snow, and graupel#1027liujake merged 1 commit intorelease-v4.1.4from
liujake merged 1 commit intorelease-v4.1.4from
Conversation
modified: da_cld_eff_radius.inc
Contributor
|
@liujake @jjguerrette
I have reviewed this, but am not allowed to approve |
liujake
approved these changes
Dec 4, 2019
jjguerrette
approved these changes
Dec 4, 2019
Contributor
|
@davegill, I agree that this should go on the release branch. Is it ok to merge now? I remember there were issues recently... |
Contributor
|
@jjguerrette |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: effective radius, lamda calculation
SOURCE: Yali Wu (NCAR)
DESCRIPTION OF CHANGES: Subroutine
da_cld_eff_radiususes exponential distribution for calculating the effective radius of different hydrometeor particles.Slope parameters should be calculated following:
but this was incorrectly typed, so that rho is in the numerator:
where, x denotes rain, snow, and graupel.
LIST OF MODIFIED FILES:
M var/da/da_radiance/da_cld_eff_radius.inc
TESTS CONDUCTED: Conducted tests before and after bugfix on Cheyenne. The model simulated MW radiances were slightly improved for a typhoon case, while the simulated IR radiances seemed to have no difference.