Skip to content

Fixing sms_3dtke km_opt=5 which breaks km_opt=2 #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janmandel wants to merge 8 commits into from
Closed

Fixing sms_3dtke km_opt=5 which breaks km_opt=2 #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
57dc293
./compile em_fire; cd test/em_fire/two_fires; ./ideal.exe; ./wrf.exe …
janmandel Nov 10, 2019
b6407f3
commented out package sms_3dtke km_opt=5 in Registry/Registry.EM_COMMON
janmandel Nov 10, 2019
d15699b
Merge branch '3DTKE-fix' of https://github.com/openwfm/WRF-Fire-merge…
janmandel Nov 10, 2019
759416f
Revert "commented out package sms_3dtke km_opt=5 in Registry/Registry…
janmandel Nov 14, 2019
90d3aa4
prevening access out of bounds on k for staggered variables
janmandel Oct 27, 2019
97caa9a
deleting l_scale from package sms_3dtke
janmandel Nov 14, 2019
c7d10a1
rm th_h_tend from registry package sms_3dtke km_opt=5 because it is u…
janmandel Nov 14, 2019
57780c9
rm tke_diffusion_h_tend from registry package sms_3dtke
janmandel Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Registry/Registry.EM_COMMON
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2915,7 +2915,12 @@ package mynn_dmp_edmf bl_mynn_edmf==1 - state:edmf_a,
package pbl_cloud icloud_bl==1 - state:cldfra_bl,qc_bl

#SMS-3DTKE
package sms_3dtke km_opt==5 - state:gamu,gamv,nlflux,dlk,l_scale,elmin,xkmv_meso,xkmh_t,u_h_tend,u_z_tend,v_h_tend,v_z_tend,w_h_tend,w_z_tend,th_h_tend,th_z_tend,tke_buoy_tend,tke_shear_tend,tke_production_tend,tke_diffusion_h_tend,tke_diffusion_z_tend
#jm deleting from package sms_3dtke variables used elsewhere
# l_scale
# th_h_tend
# tke_diffusion_h_tend
package sms_3dtke km_opt==5 - state:gamu,gamv,nlflux,dlk,elmin,xkmv_meso,xkmh_t,u_h_tend,u_z_tend,v_h_tend,v_z_tend,w_h_tend,w_z_tend,th_z_tend,tke_buoy_tend,tke_shear_tend,tke_production_tend,tke_diffusion_z_tend
#package sms_3dtke km_opt==5 - state:gamu,gamv,nlflux,dlk,l_scale,elmin,xkmv_meso,xkmh_t,u_h_tend,u_z_tend,v_h_tend,v_z_tend,w_h_tend,w_z_tend,th_h_tend,th_z_tend,tke_buoy_tend,tke_shear_tend,tke_production_tend,tke_diffusion_h_tend,tke_diffusion_z_tend

# dfi
package mynnpblscheme2_dfi bl_pbl_physics_dfi==5 - dfi_scalar:dfi_qke_adv
Expand Down
6 changes: 3 additions & 3 deletions phys/module_fr_fire_util.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,9 +1361,9 @@ subroutine print_chsum( id, &

if(fire_print_msg.le.0)return

ipe1=ifval(ipe.eq.ide.and.istag.ne.0,ipe+1,ipe)
kpe1=ifval(kpe.eq.kde.and.kstag.ne.0,kpe+1,kpe)
jpe1=ifval(jpe.eq.jde.and.jstag.ne.0,jpe+1,jpe)
ipe1=min(ime,ifval(ipe.eq.ide.and.istag.ne.0,ipe+1,ipe))
kpe1=min(kme,ifval(kpe.eq.kde.and.kstag.ne.0,kpe+1,kpe))
jpe1=min(jme,ifval(jpe.eq.jde.and.jstag.ne.0,jpe+1,jpe))
is=ifval(istag.ne.0,1,0)
ks=ifval(kstag.ne.0,1,0)
js=ifval(jstag.ne.0,1,0)
Expand Down