-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: typos in API naming #2212
base: master
Are you sure you want to change the base?
Conversation
So, since the function name is already incorrect, we cannot change it because it will break the current users. In this case, we have to leave it as it is until we release a more comprehensive breaking change. |
what if I prepare a deprecation instead so that no one else starts using the methods/enums with typos and uses the correct name?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, enum is not even being used.
stopRecoring
->stopRecording
GroupNotificationType.Inivite
->GroupNotificationType.Invite
This change might make a lot of code incompatible, so maybe it is better to save this for the next major release?
Before merging; I think I found one more potential typo:
https://github.com/gekkedev/wppconnect/blob/76baaca6fcb824b26f94a12339c3fda0ef7d5129/src/api/layers/sender.layer.ts#L145
Should be
"error"
in my opinion, but: Is this key from the platform or is it created by WPPC?