Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PIDController widget to new PIDController class #660

Closed
Starlight220 opened this issue Apr 13, 2020 · 3 comments · Fixed by #746
Closed

Update PIDController widget to new PIDController class #660

Starlight220 opened this issue Apr 13, 2020 · 3 comments · Fixed by #746

Comments

@Starlight220
Copy link
Member

Update the PID widget to the new PIDController, mainly the enable part.

@sciencewhiz
Copy link
Contributor

Since the old PID Controller has not been removed, I don't think the Shuffleboard PID Controller widget should only support the new widget. Either a new widget should be created (and the wpilib new PID Controller updated to use it) or the documentation should be updated to cover the differences.

@carbotaniuman
Copy link
Contributor

@PeterJohnson Disposition to close - won't fix.

@PeterJohnson
Copy link
Member

Actually, we just had a discussion on this, and the thought was we would update this widget and add a backwards compatibility widget for the old PIDController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants